fix(frontend): retry built-in CODE cold starts and show startup status in Office viewer#5705
Open
joshtrichards wants to merge 2 commits into
Open
fix(frontend): retry built-in CODE cold starts and show startup status in Office viewer#5705joshtrichards wants to merge 2 commits into
joshtrichards wants to merge 2 commits into
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
…xy readiness Signed-off-by: Josh <josh.t.richards@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve the Nextcloud Office frontend experience when using the built-in CODE server during cold start.
Previously, opening a document against the built-in CODE proxy could fail too quickly during startup:
checkProxyStatus()only retried a few timesThis change makes the frontend treat built-in CODE startup as a normal temporary state:
User impact
When the built-in CODE server is cold-starting, users should now see:
Changes
src/services/collabora.jscheckProxyStatus()starting,stopped(i.e. not yet started), orrestartingerrorsrc/view/Office.vueInsert_ButtonblockNotes
richdocumentsrichdocumentscoderichdocumentscode) in fix(proxy): make CODE cold-start handling request-independent and status-driven CollaboraOnline/richdocumentscode#343 that should further improve the UX by eliminating blocking on cold starts and also make the status API a bit more useful, but those changes are not a requirement/dependency for this PR.proxy.phpTesting
Suggested manual verification:
OKChecklist