feat: add filter-based mass selection via search modal#12901
feat: add filter-based mass selection via search modal#12901RobinAngele wants to merge 1 commit into
Conversation
RobinAngele
requested review from
ChristophWurst,
GretaD and
kesselb
as code owners
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThis PR lifts selection into Mailbox, adds a select-all UI and cross-page “select all matching” flow, converts EnvelopeList to prop-driven selection with flatIndex for global ranges, delegates range selection to Mailbox, updates favorite/unfavorite bulk actions, wires SearchMessages and MailboxThread to emit selection events, refactors envelope shift-click handling, and adds documentation and UI styles. Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/components/Mailbox.vue (1)
317-335:⚠️ Potential issue | 🟠 Major | ⚡ Quick winReset pagination and bulk-selection state when the source list changes.
These watchers clear
selection, but they leaveendReached/expandedbehind and only partially reset the select-all-matching flags. If the previous view had already reached the end, the next mailbox/filter/sort starts in a stale “fully loaded” state, which can hide further pages and prevent the new result set from using the intended bulk-select flow.Suggested reset
mailbox() { this.selection = [] + this.selectAllMatching = false + this.loadingAllMatching = false + this.endReached = false + this.expanded = false this.loadEnvelopes() .then(() => { logger.debug(`syncing mailbox ${this.mailbox.databaseId} (${this.query}) after folder change`) this.sync(false) }) }, searchQuery() { this.selection = [] this.selectAllMatching = false this.loadingAllMatching = false + this.endReached = false + this.expanded = false this.loadEnvelopes() }, sortOrder() { this.selection = [] + this.selectAllMatching = false + this.loadingAllMatching = false + this.endReached = false + this.expanded = false this.loadEnvelopes() },🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/Mailbox.vue` around lines 317 - 335, The watchers mailbox(), searchQuery(), and sortOrder() currently clear selection but leave pagination and bulk-selection state stale; update each watcher to also reset endReached (set to false), clear expanded state (reset the expanded map/array), and set selectAllMatching and loadingAllMatching to false before calling loadEnvelopes() (and before sync in mailbox()), so the new mailbox/filter/sort starts with fresh pagination and bulk-selection state; reference the mailbox(), searchQuery(), and sortOrder() watcher handlers and the component properties endReached, expanded, selectAllMatching, loadingAllMatching, selection, loadEnvelopes(), and sync().
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/MailboxThread.vue`:
- Around line 607-609: The onSelectAllMatching handler currently emits a generic
'select-all-matching' on the shared mitt bus causing every Mailbox subscriber to
react; change it to emit a scoped payload (e.g., include mailboxId or query) or
target the specific Mailbox directly. Update the onSelectAllMatching method to
call this.bus.emit('select-all-matching', { mailboxId: this.mailboxId, query:
this.currentQuery }) (or invoke a direct method on the intended Mailbox
instance) and update Mailbox subscribers to check the payload (e.g., mailboxId
or query) before starting load/select so only the intended mailbox responds.
Ensure the event name remains 'select-all-matching' but listeners in Mailbox use
the identifying field to ignore unrelated events.
In `@src/components/SearchMessages.vue`:
- Around line 578-584: The selectAllMatching() method currently calls
sendQueryEvent() and emits 'select-all-matching' inside a single
this.$nextTick(), which can let Mailbox receive a stale
MailboxThread.searchQuery prop; change the flow in selectAllMatching to call
this.sendQueryEvent() inside the first this.$nextTick(), then call a second
this.$nextTick() before emitting this.$emit('select-all-matching') so
Mailbox.onBusSelectAllMatching() receives the updated prop value and avoids
corrupting the cache key logic.
---
Outside diff comments:
In `@src/components/Mailbox.vue`:
- Around line 317-335: The watchers mailbox(), searchQuery(), and sortOrder()
currently clear selection but leave pagination and bulk-selection state stale;
update each watcher to also reset endReached (set to false), clear expanded
state (reset the expanded map/array), and set selectAllMatching and
loadingAllMatching to false before calling loadEnvelopes() (and before sync in
mailbox()), so the new mailbox/filter/sort starts with fresh pagination and
bulk-selection state; reference the mailbox(), searchQuery(), and sortOrder()
watcher handlers and the component properties endReached, expanded,
selectAllMatching, loadingAllMatching, selection, loadEnvelopes(), and sync().
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 495a2697-7608-4c97-89cd-216e17ceac3f
📒 Files selected for processing (4)
src/components/EnvelopeList.vuesrc/components/Mailbox.vuesrc/components/MailboxThread.vuesrc/components/SearchMessages.vue
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
src/components/Mailbox.vue (2)
830-846: ⚖️ Poor tradeoffConsider adding a cancellation mechanism for long-running operations.
The
while (!this.endReached)loop could run for a very long time on large mailboxes, especially over slow connections. If the user changes the filter, navigates away, or the component unmounts during loading, the loop continues until completion.Consider:
- Adding an abort flag checked in the loop
- Implementing a page limit (e.g., max 50 pages)
- Checking component mount state before state updates
♻️ Example cancellation pattern
async selectAllMatchingAction() { this.loadingAllMatching = true this.selectAllMatching = true + this._selectAllAborted = false try { // Load remaining pages until all envelopes are fetched - while (!this.endReached) { + while (!this.endReached && !this._selectAllAborted) { await this.loadMore() } + if (this._selectAllAborted) { + return + } // Now select all loaded envelopes this.selection = this.flatEnvelopeList.map((e) => e.databaseId) } catch (error) { logger.error('Failed to load all matching envelopes', { error }) } finally { this.loadingAllMatching = false } },Then set
this._selectAllAborted = trueinunselectAll()and watchers that reset state.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/Mailbox.vue` around lines 830 - 846, The selectAllMatchingAction can run indefinitely; add a cancellable pattern: introduce a boolean flag (e.g. this._selectAllAborted) and a maxPage cap (e.g. const MAX_SELECT_PAGES = 50) and modify selectAllMatchingAction to check both the abort flag and page cap inside the while (!this.endReached) loop before each await this.loadMore() and break if triggered; ensure you check the abort flag before assigning this.selection or calling this.flatEnvelopeList, and clear loadingAllMatching on abort; set this._selectAllAborted = true from unselectAll(), relevant filter-change watchers, and the component beforeDestroy/unmounted hook so the in-flight loop exits and avoids updating state after unmount.
36-48: 💤 Low valueDead code: loading icon inside the banner will never render.
The banner's
v-ifcondition includes!selectAllMatching, butloadingAllMatchingandselectAllMatchingare always set together (both inselectAllMatchingActionandonBusSelectAllMatching). WhenloadingAllMatchingis true,selectAllMatchingis also true, so the banner won't render and theNcLoadingIconon line 39 is unreachable.Consider removing the loading icon from the banner or adjusting the banner's visibility condition if loading state should be shown here.
♻️ Suggested fix
<div v-if="allSelected && !selectAllMatching && flatEnvelopeList.length < totalEnvelopeCount" class="select-all-banner"> - <NcLoadingIcon v-if="loadingAllMatching" :size="16" /> <span>{{ n('mail',🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/Mailbox.vue` around lines 36 - 48, The banner's v-if (allSelected && !selectAllMatching && flatEnvelopeList.length < totalEnvelopeCount) prevents loadingAllMatching from ever being visible because selectAllMatching is set alongside loadingAllMatching in selectAllMatchingAction and onBusSelectAllMatching; either remove the unreachable NcLoadingIcon or change the banner condition to allow the loading state — e.g. update the v-if to include loadingAllMatching (allSelected && (loadingAllMatching || !selectAllMatching) && flatEnvelopeList.length < totalEnvelopeCount) so NcLoadingIcon can render while select-all is in progress, or simply delete the NcLoadingIcon element if you prefer not to show loading there.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/Mailbox.vue`:
- Around line 21-28: The checkbox is listening to the wrong event: change the
event handler on the NcCheckboxRadioSwitch from `@update`:checked to
`@update`:model-value so toggles actually invoke your handlers; update the
component invocation that references selectMode and the methods selectAll() /
unselectAll() to use `@update`:model-value="selectMode ? unselectAll() :
selectAll()" so the v-model update triggers those functions.
---
Nitpick comments:
In `@src/components/Mailbox.vue`:
- Around line 830-846: The selectAllMatchingAction can run indefinitely; add a
cancellable pattern: introduce a boolean flag (e.g. this._selectAllAborted) and
a maxPage cap (e.g. const MAX_SELECT_PAGES = 50) and modify
selectAllMatchingAction to check both the abort flag and page cap inside the
while (!this.endReached) loop before each await this.loadMore() and break if
triggered; ensure you check the abort flag before assigning this.selection or
calling this.flatEnvelopeList, and clear loadingAllMatching on abort; set
this._selectAllAborted = true from unselectAll(), relevant filter-change
watchers, and the component beforeDestroy/unmounted hook so the in-flight loop
exits and avoids updating state after unmount.
- Around line 36-48: The banner's v-if (allSelected && !selectAllMatching &&
flatEnvelopeList.length < totalEnvelopeCount) prevents loadingAllMatching from
ever being visible because selectAllMatching is set alongside loadingAllMatching
in selectAllMatchingAction and onBusSelectAllMatching; either remove the
unreachable NcLoadingIcon or change the banner condition to allow the loading
state — e.g. update the v-if to include loadingAllMatching (allSelected &&
(loadingAllMatching || !selectAllMatching) && flatEnvelopeList.length <
totalEnvelopeCount) so NcLoadingIcon can render while select-all is in progress,
or simply delete the NcLoadingIcon element if you prefer not to show loading
there.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: e480ccd4-a6cf-4ccc-9a40-65b3f878b3f0
📒 Files selected for processing (2)
src/components/EnvelopeList.vuesrc/components/Mailbox.vue
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/components/EnvelopeList.vue (1)
393-404: 💤 Low valueConsider removing redundant cleanup code.
The new cleanup logic (lines 395-399) correctly removes vanished envelope IDs from selection and emits the cleaned array. The older
differenceWithcleanup (lines 400-403) setsflags.selected = falseon envelopes that are no longer insortedEnvelops, which has no practical effect since those envelopes are already removed from the rendered list. This code could be removed for clarity.♻️ Suggested cleanup
sortedEnvelops(newVal, oldVal) { // Unselect vanished envelopes by emitting cleaned selection const newIds = new Set(newVal.map((env) => env.databaseId)) const cleanedSelection = this.selection.filter((id) => newIds.has(id)) if (cleanedSelection.length !== this.selection.length) { this.$emit('update:selection', cleanedSelection, this.envelopes) } - differenceWith((a, b) => a.databaseId === b.databaseId, oldVal, newVal) - .forEach((env) => { - env.flags.selected = false - }) },🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/EnvelopeList.vue` around lines 393 - 404, Remove the redundant cleanup in the sortedEnvelops watcher: the initial block that builds newIds, computes cleanedSelection from this.selection and emits update:selection already cleans vanished IDs, so delete the subsequent differenceWith(...).forEach(env => env.flags.selected = false) code path (referenced as differenceWith in the sortedEnvelops watcher which manipulates env.flags.selected) to avoid dead/unused state changes while keeping the selection cleanup and this.$emit('update:selection', cleanedSelection, this.envelopes) intact.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/components/EnvelopeList.vue`:
- Around line 393-404: Remove the redundant cleanup in the sortedEnvelops
watcher: the initial block that builds newIds, computes cleanedSelection from
this.selection and emits update:selection already cleans vanished IDs, so delete
the subsequent differenceWith(...).forEach(env => env.flags.selected = false)
code path (referenced as differenceWith in the sortedEnvelops watcher which
manipulates env.flags.selected) to avoid dead/unused state changes while keeping
the selection cleanup and this.$emit('update:selection', cleanedSelection,
this.envelopes) intact.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 32a554d8-9c2d-4cd5-bfdc-7a6234f76eed
📒 Files selected for processing (1)
src/components/EnvelopeList.vue
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/components/Envelope.vue (1)
1-4:⚠️ Potential issue | 🟠 Major | ⚡ Quick winUpdate SPDX header to the required repository format.
Line 2 and Line 3 do not match the mandatory SPDX strings for Vue files in this repository (year/text and identifier key).
🔧 Proposed fix
<!-- - - SPDX-FileCopyrightText: 2018 Nextcloud GmbH and Nextcloud contributors - - SPDX-License-Identifier: AGPL-3.0-or-later + - SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors + - SPDX-Identifier: AGPL-3.0-or-later -->As per coding guidelines "
{lib,src,tests}/**/*.{php,js,vue}: Every file must include an SPDX license header" and "SPDX license header format must be:SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributorsandSPDX-Identifier: AGPL-3.0-or-later".🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/Envelope.vue` around lines 1 - 4, Update the SPDX header in Envelope.vue to the repository-mandated format by replacing the existing two header lines with the exact required strings: "SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors" and "SPDX-Identifier: AGPL-3.0-or-later"; locate the existing header comment at the top of src/components/Envelope.vue and swap those two lines so the file matches the project's SPDX header rules.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@src/components/Envelope.vue`:
- Around line 1-4: Update the SPDX header in Envelope.vue to the
repository-mandated format by replacing the existing two header lines with the
exact required strings: "SPDX-FileCopyrightText: 2026 Nextcloud GmbH and
Nextcloud contributors" and "SPDX-Identifier: AGPL-3.0-or-later"; locate the
existing header comment at the top of src/components/Envelope.vue and swap those
two lines so the file matches the project's SPDX header rules.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: f1de2789-e604-4606-890e-aa1cb989082a
📒 Files selected for processing (1)
src/components/Envelope.vue
RobinAngele
force-pushed
the
feat/filter-mass-select
branch
from
d96ac21 to
c5a8cfd
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/components/Mailbox.vue (1)
323-341:⚠️ Potential issue | 🟠 Major | ⚡ Quick winReset pagination and mass-selection flags when the result set changes.
These watchers clear
selection, but they leaveendReached/expandedbehind, andmailbox/sortOrderalso leave the bulk-selection flags behind. After fully loading one folder or filter, the next one can start withendReached = true, which hides pagination and makes the new select-all flow stop early.Suggested fix
watch: { mailbox() { - this.selection = [] + this.unselectAll() + this.endReached = false + this.expanded = false this.loadEnvelopes() .then(() => { logger.debug(`syncing mailbox ${this.mailbox.databaseId} (${this.query}) after folder change`) this.sync(false) }) }, searchQuery() { - this.selection = [] - this.selectAllMatching = false - this.loadingAllMatching = false + this.unselectAll() + this.endReached = false + this.expanded = false this.loadEnvelopes() }, sortOrder() { - this.selection = [] + this.unselectAll() + this.endReached = false + this.expanded = false this.loadEnvelopes() }, },🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/Mailbox.vue` around lines 323 - 341, The mailbox(), searchQuery(), and sortOrder() watchers currently only clear selection but must also reset pagination and mass-selection flags to avoid carrying state into the next result set; update each watcher (mailbox(), searchQuery(), sortOrder()) to set endReached = false and expanded = false and also clear selectAllMatching = false and loadingAllMatching = false before calling loadEnvelopes()/sync(), ensuring any pagination cursor or offset state used by loadEnvelopes() is effectively reset for the new folder/filter.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/Mailbox.vue`:
- Around line 37-47: The banner/button currently uses totalEnvelopeCount as if
it were the full match total even when endReached is false; update the template
logic around the banner (the v-if using allSelected, selectAllMatching and
flatEnvelopeList.length < totalEnvelopeCount) and the copy/CTA (the span,
NcButton and their use of totalEnvelopeCount) so that exact "all matching"
counts are only shown when endReached === true—otherwise show a non-exact CTA
like "Select all visible messages" or "Select all matching messages" (no exact
number) and, if desired, show a progressive "Select all {visible} on this page"
with a secondary loader state (loadingAllMatching) that then resolves to the
exact count when endReached becomes true; apply the same change to the second
identical block that uses the same variables and selectAllMatchingAction.
- Around line 831-846: The selectAllMatchingAction loop can spin indefinitely
when loadMore() throws because endReached never flips; update
selectAllMatchingAction so that if loadMore() rejects you break the while loop
(or set endReached=true) before rethrowing or logging. Specifically, inside
selectAllMatchingAction around the while (!this.endReached) { await
this.loadMore() } call handle errors from loadMore() (or wrap each await
this.loadMore() in its own try/catch) and on error log via logger.error and then
break the loop so the method can proceed to set this.selection from
this.flatEnvelopeList and finish (preserve the existing finally that clears
this.loadingAllMatching and leave this.selectAllMatching true/false behavior
unchanged).
---
Outside diff comments:
In `@src/components/Mailbox.vue`:
- Around line 323-341: The mailbox(), searchQuery(), and sortOrder() watchers
currently only clear selection but must also reset pagination and mass-selection
flags to avoid carrying state into the next result set; update each watcher
(mailbox(), searchQuery(), sortOrder()) to set endReached = false and expanded =
false and also clear selectAllMatching = false and loadingAllMatching = false
before calling loadEnvelopes()/sync(), ensuring any pagination cursor or offset
state used by loadEnvelopes() is effectively reset for the new folder/filter.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 7a525e38-36d4-4e8e-8869-8d36f335f18c
📒 Files selected for processing (1)
src/components/Mailbox.vue
|
Sorry if the review rabbit caused any confusion. We enabled the integration but the config to turn auto reviews off was missing. |
|
Tested in production — all scenarios work. The two-event design handles filter changes and mass loading reliably. Ready for review when you have time. |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Actionable comments posted: 5
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Nextcloud_Mail_Select_All_and_Mass_Selection.md`:
- Around line 168-177: Update the documented checkbox examples to match the
merged Mailbox.vue API: replace the deprecated `@update`:checked usage with
`@update`:model-value and show the new behavior where the handler toggles
selectMode to call selectAll() or unselectAll(); specifically reference the
NcCheckboxRadioSwitch component and the selectMode/selectAll/unselectAll
functions so readers understand to wire the checkbox's `@update`:model-value to
toggle selectMode which in turn invokes selectAll() or unselectAll().
- Around line 46-50: Add language identifiers to all unlabeled fenced code
blocks (e.g., the diagram block that starts with "Mailbox └── EnvelopeList (owns
`selection[]` locally)"), using text for ASCII diagrams and select vue, js, or
http for the other code snippets as appropriate; update each fence to start with
```text, ```vue, ```js or ```http so markdownlint MD040 warnings are cleared
across the file (apply the same change to the other unlabeled blocks mentioned
in the review).
In `@src/components/Mailbox.vue`:
- Around line 831-837: The onUpdateSelection merge leaves IDs that no longer
exist in the current visible mailbox, so update the merge to first build a Set
of current visible envelope IDs (e.g., from the component's visible/envelopes
array) and then filter the resulting selection against that set; specifically,
in onUpdateSelection replace the final assignment so it removes any id not
present in visibleIds after merging the filtered old selection and
childSelection, ensuring this.selection contains only IDs currently visible.
- Around line 244-249: flatEnvelopeList currently flattens from the original
source arrays (this.groupEnvelopes / this.envelopesToShow), which is out of sync
with the rendered sort order and causes shift-click range selection mismatches;
change flatEnvelopeList to return the flattened list derived from the
rendered/sorted source (use this.sortedEnvelops or the existing computed that
the UI uses for rendering) instead of the unsorted arrays so selections match
rendered rows — i.e. when a sorted/ordered computed like sortedEnvelops exists
return that flattened list (or map sorted entries to their envelope objects when
grouped), otherwise fall back to this.envelopesToShow.
- Around line 882-912: The mass-select flow in onBusSelectAllMatching sets
loadingAllMatching to true which causes the selection watcher to skip emitting
'section-selected', and it never gets emitted after completion; fix by, at the
end of onBusSelectAllMatching (after the finally sets this.loadingAllMatching =
false), explicitly emit the section-clearing event the watcher would have
emitted (i.e. emit the 'section-selected' event with the appropriate payload to
clear sibling section selection) so the Priority Inbox state is updated;
reference onBusSelectAllMatching, loadingAllMatching, the selection watcher, and
the 'section-selected' event when locating where to add the emit.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 821c2645-d20d-47bb-a8ca-d516cb257b79
📒 Files selected for processing (5)
Nextcloud_Mail_Select_All_and_Mass_Selection.mdsrc/components/EnvelopeList.vuesrc/components/Mailbox.vuesrc/components/MailboxThread.vuesrc/components/SearchMessages.vue
🚧 Files skipped from review as they are similar to previous changes (2)
- src/components/MailboxThread.vue
- src/components/SearchMessages.vue
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/Mailbox.vue`:
- Around line 903-913: The mass-select loop currently breaks on a failed
loadMore(effectiveQuery) but still proceeds to set this.selectAllMatching and
this.selection from this.flatEnvelopeList, which can silently produce a partial
selection and exceed MAX_SELECT_MESSAGES; change the flow so that if
loadMore(...) returns false you immediately clear/disable select-all mode (set
this.selectAllMatching = false), do not populate this.selection from partial
results, and set this.selectionLimitReached = true; additionally, after the
fetch loop always enforce a strict cap by truncating any assignment to
this.selection (e.g., use the first MAX_SELECT_MESSAGES of
this.flatEnvelopeList) and log the cap, and apply the same guard in the later
block that sets selection (the block around lines 916-919) so both places
consistently abort select-all on failed load and enforce the hard
MAX_SELECT_MESSAGES cap.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 3db28979-8b9d-4a6a-a7bd-2896b8c76045
📒 Files selected for processing (2)
Nextcloud_Mail_Select_All_and_Mass_Selection.mdsrc/components/Mailbox.vue
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
RobinAngele
force-pushed
the
feat/filter-mass-select
branch
from
9f79425 to
af4769f
Compare
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
RobinAngele
force-pushed
the
feat/filter-mass-select
branch
2 times, most recently
from
9d1ac5f to
ccc59be
Compare
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
🧹 Nitpick comments (2)
src/components/Mailbox.vue (2)
962-968: 💤 Low valueConsider whether resetting
expandedon unselect is the desired UX.
unselectAll()resetsexpanded = false(line 967), which collapses the list back to the initial page size. Users who scrolled to load more messages and then unselect might expect the list to remain expanded.If this is intentional (clean reset), the current behavior is fine. If users should retain their scroll position and loaded messages, consider removing the
expanded = falseline.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/Mailbox.vue` around lines 962 - 968, The unselectAll() method currently forces the message list to collapse by setting this.expanded = false; to preserve the user's loaded/expanded view when they clear selection, remove the this.expanded = false assignment from unselectAll() (leaving selection, selectAllMatching, loadingAllMatching, and selectionLimitReached resets intact); if collapse-on-unselect is indeed desired, instead add a comment above unselectAll() explaining that collapsing is intentional for a full reset so future readers know this side-effect is expected.
426-426: 💤 Low valueMinor typo in log message.
"initalization" should be "initialization".
- logger.debug(`syncing folder ${this.mailbox.databaseId} (${this.searchQuery}) during cache initalization`) + logger.debug(`syncing folder ${this.mailbox.databaseId} (${this.searchQuery}) during cache initialization`)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/Mailbox.vue` at line 426, Fix the typo in the debug log message in Mailbox.vue: update the logger.debug call that references this.mailbox.databaseId and this.searchQuery to use "initialization" instead of "initalization" so the log reads "syncing folder ${this.mailbox.databaseId} (${this.searchQuery}) during cache initialization".
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/components/Mailbox.vue`:
- Around line 962-968: The unselectAll() method currently forces the message
list to collapse by setting this.expanded = false; to preserve the user's
loaded/expanded view when they clear selection, remove the this.expanded = false
assignment from unselectAll() (leaving selection, selectAllMatching,
loadingAllMatching, and selectionLimitReached resets intact); if
collapse-on-unselect is indeed desired, instead add a comment above
unselectAll() explaining that collapsing is intentional for a full reset so
future readers know this side-effect is expected.
- Line 426: Fix the typo in the debug log message in Mailbox.vue: update the
logger.debug call that references this.mailbox.databaseId and this.searchQuery
to use "initialization" instead of "initalization" so the log reads "syncing
folder ${this.mailbox.databaseId} (${this.searchQuery}) during cache
initialization".
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 5c7ed04a-9626-463e-acd5-63dab2e7983a
📒 Files selected for processing (3)
Nextcloud_Mail_Select_All_and_Mass_Selection.mdsrc/components/EnvelopeList.vuesrc/components/Mailbox.vue
✅ Files skipped from review due to trivial changes (1)
- Nextcloud_Mail_Select_All_and_Mass_Selection.md
🚧 Files skipped from review as they are similar to previous changes (1)
- src/components/EnvelopeList.vue
| v-if="isAtLeastOneSelectedFavorite" | ||
| variant="tertiary" | ||
| :title="n('mail', 'Unfavorite {number}', 'Unfavorite {number}', selection.length, { number: selection.length })" | ||
| @click.prevent="unfavoriteAll"> |
There was a problem hiding this comment.
Sorry to ask this, but am I talking to Robin or the agent? The PR is merged.
There was a problem hiding this comment.
@ChristophWurst it's Robin. Sorry for the noise — I rebased, squashed, removed the doc file, and dropped the duplicate from #12899. One clean commit now. Ready for review :)
| @@ -0,0 +1,509 @@ | |||
| # Nextcloud Mail — Select All & Mass Selection Feature | |||
RobinAngele
force-pushed
the
feat/filter-mass-select
branch
4 times, most recently
from
dd08af9 to
120169a
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
RobinAngele
force-pushed
the
feat/filter-mass-select
branch
from
120169a to
652ec41
Compare
Add a 'Select all matching' button to the search parameters dialog and enable selecting all messages matching a filter across all pages. Depends on: nextcloud#12900 Closes nextcloud#4285 Closes nextcloud#7880 Refs nextcloud#6070 Refs nextcloud#7276 AI-assisted: Cline (Claude) Signed-off-by: RobinAngele <robin@robin4consulting.com>
RobinAngele
force-pushed
the
feat/filter-mass-select
branch
from
652ec41 to
bb9670c
Compare
2 participants
Depends on: #12900
Closes #4285
Closes #7880
Closes #11527
Refs #6070
Refs #7276
Refs #11526
Refs #11973
Refs #11420
Summary
Built on #12900 which centralised selection state in
Mailbox, this PR completes #4285 and #7880 by adding three complementary ways to select messages for bulk actions:Checkbox row — click the checkbox at the top of the list to select all currently loaded messages at once.
Select-all banner — after clicking the checkbox to select all loaded messages, if more pages remain a banner appears. Clicking it loads all remaining pages and selects every message in the current view.
Search modal "Select all matching" (new primary button) — open the search dialog, set any filter combination, and click "Select all matching". The modal closes, all matching messages are loaded across all pages, and the entire result set is selected ready for bulk action.
In all three flows, selection is capped at 500 messages to prevent OOM in unified mailboxes (which fan out to N IMAP accounts per page fetch). When the cap is reached a warning explains it and suggests narrowing the filter or working in batches.
Also fixes shift-click range selection across date groups (#11527): shift-clicking a message in a different date group from the last-selected one now correctly selects all messages in between.
Also adds full Priority inbox support: each of the four sections (Favorites, Follow-up, Important, Other) gets its own independent select-all flow. Selecting messages in one section automatically clears the selection in any other, since each section has its own action toolbar and cross-section bulk operations are not possible.
Screenshots
Search modal — new "Select all matching" primary button
Mass-select result — N selected with action toolbar
Priority inbox mutual exclusion — section cleared toast
Architecture
Component interaction
State flows down via props, changes flow up via Vue events, and cross-instance coordination uses the shared mitt bus.
Key design decisions
Every
MailboxThreadview mounts at least twoMailboxinstances on the same bus — a Favorites section and a Main section. The Priority inbox (PRIORITY_INBOX_ID) extends this to four sections (Favorites, Follow-up, Important, Other), all withisPriorityInbox=true. The unified inbox (UNIFIED_INBOX_ID) uses the same two-section layout as a regular folder and requires no special handling. The decisions below address the non-obvious coordination problems the multi-instance shared-bus pattern creates.1. Capturing the settled query before loading
Priority inbox sections inject a query suffix one Vue render tick after the parent's
searchQueryprop changes. Starting mass-select immediately would use a stale query and corrupt the cache key. The fix is to raise a lock flag (loadingAllMatching) before yielding — which simultaneously blocks thesearchQuerywatcher from triggering a competing reload — then read the settled, section-filtered query after the tick.2. Mutual exclusion between sections
Each section has its own independent action toolbar, so a selection spanning two sections can't be acted upon in a single bulk operation. When a section's selection goes from empty to non-empty (user-initiated), it broadcasts a
section-selectedevent on the shared bus. Any sibling holding a selection clears itself with an info toast.3. Concurrent mass-selects must not interfere
The search modal triggers mass-select on all sections simultaneously — each independently loads its own filtered pages. Mutual exclusion must not fire on completion: each finishing section would otherwise clear the others' just-loaded selections. So
section-selectedis emitted only on user-initiated transitions, never at the end of a programmatic mass-load.4. OOM protection: 500-message cap
The unified inbox fans out to N IMAP accounts per page fetch. Without a ceiling, large multi-account selections exhaust client memory. The loop halts at 500 and shows a visible warning rather than silently truncating.
5. Keeping the spinner visible during mass-select
Mass-select forces a cache invalidation to guarantee a fresh fetch. Without a guard, this triggers
LoadingSkeleton, hiding the spinner mid-operation. A!loadingAllMatchingcondition inloadEnvelopes()suppresses the skeleton so the spinner stays visible throughout.Changes
SearchMessages.vueNcDialogbutton; "Search" demoted to tertiaryselectAllMatching()setsmatch = 'allof', closes the modal, then emitsselect-all-matchingwith the full computed query string — intentionally nosendQueryEvent()to avoid a concurrent reloadcloseSearchModal()has an idempotency guard — safe to call multiple timesfilterData.mentions: coercesfalseto''somentions:falseis never appended to the IMAP query stringMailboxThread.vue@select-all-matching="onSelectAllMatching"onSearchMessagesonSelectAllMatching(query)setsthis.searchQuery = querybeforethis.bus.emit('select-all-matching')so each Priority inbox section reads the correct parent query when it captureseffectiveQueryafter its own$nextTickMailbox.vueisPriorityInboxprop — hides the select-all banner, disables envelope grouping, and shows an empty-section placeholder (mutual exclusion viasection-selectedfires on all instances regardless of this flag)loadingAllMatching/selectAllMatching/selectionLimitReacheddata flagsonBusSelectAllMatching()— full mass-select lifecycle: raises flag, yields tick, clears cache, fetches all pages, caps at 500, selects all; both failure paths (page-load error mid-loop and outer catch) now show an error toast and resetselectAllMatching(previously silent — console-only logging)loadEnvelopes()—!loadingAllMatchingguard suppressesLoadingSkeletonduring mass-selectselectionwatcher — emitssection-selectedon 0 → non-zero transition, guarded by!loadingAllMatchingonBusSectionSelected(activeQuery)— clears sibling section selection with info toast ("Selection cleared — only one Priority inbox section can be selected at a time"); self-guard viaactiveQuery !== this.searchQueryselectAllMatchingAction()— in-page banner entry point (callsonBusSelectAllMatching()directly, no bus round-trip)selectAllLabelcomputed — context-aware label:loadingAllMatchingselectModehasFilter!endReached && count > 0select-all-banner— prompts to load all matching when all visible are selected and more exist; hidden for Priority inbox; button label adapts: "Select all matching messages" when a filter is active, "Select all messages in this folder" otherwiseselect-all-limit-warning— shown in warning colour when 500-cap is hit: "Selection limited to N messages — use a filter to narrow results, or process in several batches."onUpdateSelection()— merged into single array assignment (removes intermediate empty reactive state)unselectAll()— also clearsloadingAllMatchingandexpandedbus.on/off('section-selected', ...)symmetric increated/unmountedpriorityImportantQuery,priorityOtherQuery, andfavoritesQueryconstants instead of hardcoding strings inhasFilterEnvelopeList.vue_localToggleInProgressguard on bothselectionandsortedEnvelopswatchers — prevents watchers from overwritingflags.selectedduring a local click; reset via$nextTickto survive Vue's watcher flushHow to test
Known limitations
selectionarray and fire individual API calls. A future improvement would be a server-side endpoint accepting a filter query and performing the operation without enumerating IDs client-side