Skip to content

Audio translation#601

Merged
julien-nc merged 6 commits into
mainfrom
enh/noid/audio-translation
Jul 10, 2026
Merged

Audio translation#601
julien-nc merged 6 commits into
mainfrom
enh/noid/audio-translation

Conversation

@julien-nc

@julien-nc julien-nc commented Jul 8, 2026

Copy link
Copy Markdown
Member
  • Add an audio translation provider that runs 3 sub tasks (stt, translate, tts)
  • Proxy the optional input shape of the underlying translate and tts providers (if there are some known ones)
  • Bump min NC to 35
  • Set Php 8.3 in config.platform
  • Update composer dependencies

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

julien-nc added 2 commits July 8, 2026 13:42
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
…s of the audio translation provider

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc julien-nc requested a review from janepie as a code owner July 8, 2026 12:39
@julien-nc julien-nc added enhancement New feature or request 3. to review labels Jul 8, 2026
@julien-nc julien-nc force-pushed the enh/noid/audio-translation branch from 5307384 to a71e365 Compare July 8, 2026 12:41

@lukasdotcom lukasdotcom left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test this, but looks fine.

Comment thread lib/AppInfo/Application.php Outdated
…pendencies, run cs:fix

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc julien-nc force-pushed the enh/noid/audio-translation branch from a71e365 to 8941f14 Compare July 8, 2026 15:56
// $context->registerTaskProcessingTaskType(ImageToTextTranslateTaskType::class);
// $context->registerTaskProcessingProvider(ImageToTextTranslateProvider::class);

$context->registerTaskProcessingProvider(AudioToAudioTranslateProvider::class);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we only register this if all subordinate task types have a provider available? Otherwise getPreferredTaskType throws

@julien-nc julien-nc Jul 9, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried

$availableTaskTypeIds = $this->taskProcessingManager->getAvailableTaskTypeIds();
if (in_array(AudioToText::ID, $availableTaskTypeIds, true)) {
	$context->registerTaskProcessingProvider(AudioToAudioTranslateProvider::class);
}

but at this point not all the task types are registered, on my setup I only get core:audio2audio:chat and assistant:text2sticker. Not sure if we can really check what's available here.

Comment thread lib/TaskProcessing/AudioToAudioTranslateProvider.php Outdated
Comment thread lib/TaskProcessing/AudioToAudioTranslateProvider.php Outdated
Comment thread lib/TaskProcessing/AudioToAudioTranslateProvider.php Outdated
julien-nc added 2 commits July 9, 2026 11:47
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Comment thread lib/TaskProcessing/AudioToAudioTranslateProvider.php Outdated
… AudioToAudioTranslateProvider

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc julien-nc merged commit a342c0c into main Jul 10, 2026
14 checks passed
@julien-nc julien-nc deleted the enh/noid/audio-translation branch July 10, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants