-
Notifications
You must be signed in to change notification settings - Fork 38
Feature/chat message search #574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
annaneliaa
wants to merge
9
commits into
nextcloud:main
Choose a base branch
from
annaneliaa:feature/chat-message-search
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a2f752d
feat(search): add chat message search to mapper and service with unit…
annaneliaa ce256b2
feat(search): add search endpoint to ChattyLLMController and route
annaneliaa ef7416b
enable CI
annaneliaa 002a45d
small formatting changes to make the code in line with the existing code
annaneliaa 6e4871f
feat(search)added message search to the UI: search input in sidebar, …
annaneliaa efb9192
ran composer run openai
annaneliaa a8a5ba7
feat(search): made a change to ChatService::searchMessages to pass th…
annaneliaa a9a88a5
feat(search): simple highlighting is working. the matching parts of t…
annaneliaa 8f101d9
scoped the search-query property to matching messages only. removed t…
annaneliaa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice that it debounces. I think there still is a race condition producing unexpected results.
In short: If a request is very long, another following request might finish earlier, then the first request will overwrite the second one.
Here is a sequence of actions:
The solution for that is to cancel the potentially running previous request whenever the search query changes. You can find examples of how to cancel a request in the assistant's frontend. There is one in this very file. Look for
messagesAxiosController.Wdyt?