feat: add default_action field to files-actions-menu registration#887
Conversation
0b814e3 to
38390e7
Compare
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThis PR adds a 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
|
@jvdp , could you rebase the PR when you have time? |
c757e82 to
9f54fde
Compare
|
@oleksandr-nc rebase done and also fixed up a bit. The second commit is to fix a bug found on CI. |
9f54fde to
747e363
Compare
|
@jvdp the PR looks really good! ☀️ Could you squash all commits into one? After that we can merge this |
fixes nextcloud#748 Signed-off-by: Jaap van der Plas <jvdplas@gmail.com>
1f31677 to
4809dde
Compare
|
@jvdp , thank you for taking effort and working on this - good job. |
|
@oleksandr-nc you're welcome and thanks for merging! |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
fixes #748