Release/7.0.2 - #470
Merged
Merged
Conversation
Update Jackson dependencies to version 3.1.5 in `pom.xml`
…stead of `processId`.
…elpers to use a dedicated MongoTemplate bean (`migrationMongoTemplate`) with fallback logic in multi-database setups.
…handle `processIdentifier`.
…rocessResourceId` and update related classes.
…om queries and setting it to null during migration.
…e setters consistently
…igrate role-related fields in `Case` documents
…and centralize ID translation logic with `getNewIdFromOldId`.
…and centralize ID translation logic with `getNewIdFromOldId`.
…for task and Petri net migration logic, adding `@ConditionalOnProperty` for configurability, and improving clarity in variable naming.
…permission and data field migration
…permission and data field migration
…Id` and deprecate `findByNetworkIdAndObjectId`.
…te management and enhanced executor configuration. - Added methods to `ActionDelegate` to manage asynchronous execution lifecycle (`retainForAsyncExecution`, `releaseAfterAsyncExecution`, `clearAfterExecution`). - Enhanced `AsyncRunner` with delegate state tracking and custom `actionsExecutor`. - Added `async_run.xml` test Petri net and corresponding test cases to validate asynchronous action handling.
…te management and enhanced executor configuration. - Added methods to `ActionDelegate` to manage asynchronous execution lifecycle (`retainForAsyncExecution`, `releaseAfterAsyncExecution`, `clearAfterExecution`). - Enhanced `AsyncRunner` with delegate state tracking and custom `actionsExecutor`. - Added `async_run.xml` test Petri net and corresponding test cases to validate asynchronous action handling.
- Update `server-patterns` to replace `/manage/**` with `/manage/health` - Configure `management.endpoint.shutdown.enabled` as `false` across properties - Expand `management.endpoints.web.exposure.include` for additional actuator endpoints
…logic; consolidate MongoTemplate usage to default bean.
# Conflicts: # application-engine/src/test/groovy/com/netgrif/application/engine/TestHelper.groovy # application-engine/src/test/groovy/com/netgrif/application/engine/action/ActionDelegateTest.groovy
… and `TestHelper` for consistency and clarity.
…d` and deprecate `findByNetworkIdAndObjectId`; update tests and enums accordingly.
…ariable naming consistency.
…tringQuery` with `BoolQuery`, introduce `FullTextField` model, and enhance wildcard handling.
…ce static imports with dynamic discovery, introduce `ACTION_IMPORT_PACKAGES`, and optimize class loading.
[NAE-2464] Release 1.0.1 Bugfixes
…ce static imports with dynamic discovery, introduce `ACTION_IMPORT_PACKAGES`, and optimize class loading.
- Update version to 7.0.2 in all affected `pom.xml` files - Modify `Dockerfile` and `Dockerfile.multi-stage` to use version 7.0.2 - Adjust `docker-compose.yml` to reflect the new image version
Remove the dedicated actions executor bean Log ambiguous automatic Groovy action imports instead of silently skipping them Prevent dev profile from dropping MongoDB and Elasticsearch data by default Update deprecated case repository methods to version 7.0.2 Remove obsolete migration MongoTemplate bean configuration Validate Elasticsearch full-text field boost values before applying them
…r regex handling consistency in full-text search normalization methods.
…ull-text search behavior and edge cases.
…r string normalization in full-text search
…ion for method usage
…e string replacement in full-text search normalization
[NAE-2464] Post release fixes
|
Warning Review limit reached
Next review available in: 39 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThe release updates workflow resource identifiers, asynchronous action execution, Elasticsearch full-text search, Groovy action imports, actuator exposure, migration configuration, tests, and project versions. ChangesWorkflow platform updates
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant GroovyAction
participant AsyncRunner
participant ActionDelegate
participant TaskExecutor
GroovyAction->>AsyncRunner: submit closure
AsyncRunner->>ActionDelegate: retainForAsyncExecution
AsyncRunner->>TaskExecutor: execute Runnable
TaskExecutor->>ActionDelegate: releaseAfterAsyncExecution
ActionDelegate->>ActionDelegate: clear after execution completes
Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
coderabbitai
Bot
added
breaking change
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 16
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
nae-object-library/src/main/java/com/netgrif/application/engine/objects/petrinet/domain/roles/ProcessRole.java (1)
62-68: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick winFix the field mismatch between the guard and the constructed
ProcessResourceId.The guard checks
this.getProcessId() == null, but theelsebranch constructs_idfromprocessIdentifier, notprocessId. Since fields cannot be set before a no-arg constructor runs,getProcessId()is alwaysnullhere, so theelsebranch is unreachable in practice. This mismatch indicates the guard was not updated when the identifier field changed fromprocessIdtoprocessIdentifier.Check
processIdentifierinstead ofprocessId, to align the guard with the value actually used to build_id.🐛 Proposed fix
public ProcessRole() { - if (this.getProcessId() == null) { + if (this.getProcessIdentifier() == null) { _id = new ProcessResourceId(); } else { _id = new ProcessResourceId(processIdentifier, new ObjectId()); } }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@nae-object-library/src/main/java/com/netgrif/application/engine/objects/petrinet/domain/roles/ProcessRole.java` around lines 62 - 68, Update the no-argument ProcessRole constructor’s guard to check processIdentifier instead of getProcessId(), keeping the ProcessResourceId construction aligned with the identifier used in the else branch.nae-object-library/src/main/java/com/netgrif/application/engine/objects/workflow/domain/ProcessResourceId.java (1)
95-129: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick winFix the short process ID round-trip for non-ASCII identifiers.
generateShortProcessIdentifier()encodesprocessIdentifier.getBytes()vianew BigInteger(1, ...), anddecodeShortProcessIdentifier()usesnumber.toByteArray()to decode.BigInteger.toByteArray()returns a minimal two's-complement result including a sign byte, so any encoded process identifier whose encoding produces a leading byte with bit 7 set is decoded with a spurious leading NUL byte. Use a fixed positive sentinel byte before encoding so the magnitude has an explicit zero sign, then strip that byte on decode; reuse one decodedBigIntegerfor both decode methods.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@nae-object-library/src/main/java/com/netgrif/application/engine/objects/workflow/domain/ProcessResourceId.java` around lines 95 - 129, Update generateShortProcessIdentifier to prepend a fixed zero sentinel byte before constructing the positive BigInteger, ensuring the encoded magnitude preserves the original byte sequence. In decodeShortProcessIdentifier, convert the decoded BigInteger to bytes once and remove that sentinel before creating the identifier, reusing the same decoded value across the decode paths.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@application-engine/src/main/groovy/com/netgrif/application/engine/AsyncRunner.groovy`:
- Around line 42-44: Update AsyncRunner.execute and its actionsExecutor
configuration to use a dedicated, bounded executor for action-triggered
asynchronous work instead of the shared qualified taskExecutor bean. Keep the
executor isolated from unrelated `@Async` workloads while preserving execute’s
Runnable submission behavior.
- Around line 52-72: Add a focused unit test for AsyncRunner.findActionDelegate
using an outer wrapper closure delegated to an ActionDelegate and a nested
closure passed to async.run, verifying the delegate is found through the nested
closure traversal. Ensure the test reflects real action-closure wiring and fails
if the delegate/owner traversal no longer reaches the ActionDelegate.
- Around line 21-40: Update the Runnable in AsyncRunner.run so exceptions from
closure() are caught, logged with log.error(...) including the throwable, and
then rethrown or otherwise handled consistently with the existing async failure
behavior; preserve the finally block’s release(actionDelegate, released)
cleanup.
In
`@application-engine/src/main/groovy/com/netgrif/application/engine/migration/helpers/CaseMigrationHelper.groovy`:
- Around line 465-467: Update CaseMigrationHelper.migratePetriNet at
application-engine/src/main/groovy/com/netgrif/application/engine/migration/helpers/CaseMigrationHelper.groovy:465-467
to preserve the case’s old resource ID and migrate linked task references when
setting the new _id. In TaskMigrationHelper at
application-engine/src/main/groovy/com/netgrif/application/engine/migration/helpers/TaskMigrationHelper.groovy:271-276,
set oldTask.caseId to the migrated case string ID before saving.
In
`@application-engine/src/main/java/com/netgrif/application/engine/elastic/service/ElasticCaseService.java`:
- Around line 433-446: Update the full-text query construction around the
fullTextTerms/fullTextFields loop to avoid generating leading-wildcard wildcard
clauses for every term and field. Preserve substring matching by querying an
appropriately configured n-gram subfield with match queries, or otherwise retain
prefix-searchable behavior without prepending “*”; ensure the resulting per-term
field matching and boost semantics remain intact.
- Around line 559-573: The normalizeFullTextSearch method should not call
Matcher.quoteReplacement, since it escapes dollar signs and corrupts terms such
as $100 before wildcard escaping. Replace that normalization step with direct
backslash handling, preserve the existing whitespace and dangling-escape
cleanup, and remove the now-unused Matcher import.
In
`@application-engine/src/main/java/com/netgrif/application/engine/event/GroovyShellFactory.java`:
- Around line 27-31: Update GroovyShellFactory’s ACTION_IMPORT_PACKAGES
initialization to source scanned packages from the existing ActionsProperties
configuration instead of a hardcoded list. Reuse the configured imports,
starImports, or staticStarImports values as appropriate, preserving the current
defaults when no values are configured and allowing consumers to add packages
without code changes.
- Around line 63-81: Update findAllActionImportClasses and the class-discovery
flow so an individual class load or scan failure is logged and skipped rather
than propagated. Ensure loadClass handles both ClassNotFoundException and
linkage-related failures, while findAllClassesUsingClassLoader tolerates
per-class discovery failures; preserve discovery of all remaining valid classes
so getGroovyShell can initialize successfully.
- Around line 144-147: Update the resource filtering loop in GroovyShellFactory
to identify and exclude test classes using build-agnostic classpath or source
metadata rather than matching resource.getDescription() against “test-classes”.
Preserve inclusion of production resources and use an explicit configuration,
marker type, or equivalent reliable test-class distinction.
In
`@application-engine/src/main/java/com/netgrif/application/engine/workflow/domain/repositories/CaseRepository.java`:
- Around line 41-65: Add legacy-field fallback handling for composite ID
lookups: in CaseRepository, make findById() try the deprecated
_id.shortProcessId query when findByNetworkIdentifierAndObjectId() finds
nothing; apply the equivalent migration/fallback in ProcessRoleRepository; and
update CaseEventHandler delete-ID construction to support legacy shortProcessId
values. Affected sites:
application-engine/src/main/java/com/netgrif/application/engine/workflow/domain/repositories/CaseRepository.java:41-65,
application-engine/src/main/java/com/netgrif/application/engine/petrinet/domain/roles/ProcessRoleRepository.java:129-156,
and
application-engine/src/main/java/com/netgrif/application/engine/workflow/service/CaseEventHandler.java:60.
In `@application-engine/src/main/resources/application.yaml`:
- Around line 124-129: Remove heapdump from the
management.endpoints.web.exposure.include allowlist and delete the
management.endpoint.heapdump access: unrestricted configuration. Keep the
remaining actuator endpoint exposure and shutdown settings unchanged.
In
`@application-engine/src/test/groovy/com/netgrif/application/engine/action/ActionDelegateTest.groovy`:
- Around line 183-197: Strengthen testAsyncRunAction by asserting the
asynchronous action’s observable result, not only successful net import and case
creation. Exercise the retain/release lifecycle through the async action in
async_run.xml—preferably by writing to a case field and polling until the
expected value appears with a bounded timeout, or by directly testing
AsyncRunner/ActionDelegate with a controllable TaskExecutor—so delegate lookup
or cleared fields cause the test to fail.
- Around line 191-195: Update the CreateCaseParams construction in
ActionDelegateTest to use the processIdentifier builder with the net’s process
identifier instead of processId with net.getNet().getStringId(), ensuring
createCase resolves the intended process identity.
In
`@nae-object-library/src/main/java/com/netgrif/application/engine/objects/workflow/domain/ProcessResourceId.java`:
- Line 4: Remove the class-level `@Setter` from ProcessResourceId and eliminate
setters for the identity fields objectId, shortProcessIdentifier, and
shortProcessId; preserve constructor initialization and retain or scope setters
only for fields that genuinely require external mutation.
- Around line 28-59: Backfill the non-deprecated shortProcessIdentifier from
legacy shortProcessId when ProcessResourceId data is loaded, including persisted
process resources and Cases, before getFullId() is used. Update
CaseEventHandler.onAfterDelete and TaskEventHandler to use the normalized
shortProcessIdentifier value while retaining compatibility with legacy
documents.
In
`@nae-object-library/src/main/java/com/netgrif/application/engine/objects/workflow/domain/Task.java`:
- Around line 177-181: Update the lazy initialization guard in get_id() to check
processIdentifier, matching the field passed to ProcessResourceId and preventing
null-based identifiers. Apply the same field alignment to the Task() constructor
guard if retained, without changing the existing setter-based initialization
behavior.
---
Outside diff comments:
In
`@nae-object-library/src/main/java/com/netgrif/application/engine/objects/petrinet/domain/roles/ProcessRole.java`:
- Around line 62-68: Update the no-argument ProcessRole constructor’s guard to
check processIdentifier instead of getProcessId(), keeping the ProcessResourceId
construction aligned with the identifier used in the else branch.
In
`@nae-object-library/src/main/java/com/netgrif/application/engine/objects/workflow/domain/ProcessResourceId.java`:
- Around line 95-129: Update generateShortProcessIdentifier to prepend a fixed
zero sentinel byte before constructing the positive BigInteger, ensuring the
encoded magnitude preserves the original byte sequence. In
decodeShortProcessIdentifier, convert the decoded BigInteger to bytes once and
remove that sentinel before creating the identifier, reusing the same decoded
value across the decode paths.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 2bfd2081-7281-461d-8634-52f525b81fca
📒 Files selected for processing (40)
DockerfileDockerfile.multi-stageapplication-engine/pom.xmlapplication-engine/src/main/groovy/com/netgrif/application/engine/AsyncRunner.groovyapplication-engine/src/main/groovy/com/netgrif/application/engine/migration/helpers/CaseMigrationHelper.groovyapplication-engine/src/main/groovy/com/netgrif/application/engine/migration/helpers/PetriNetMigrationHelper.groovyapplication-engine/src/main/groovy/com/netgrif/application/engine/migration/helpers/TaskMigrationHelper.groovyapplication-engine/src/main/groovy/com/netgrif/application/engine/petrinet/domain/dataset/logic/action/ActionDelegate.groovyapplication-engine/src/main/java/com/netgrif/application/engine/configuration/MongoClientConfiguration.javaapplication-engine/src/main/java/com/netgrif/application/engine/configuration/groovy/GroovyShellConfiguration.javaapplication-engine/src/main/java/com/netgrif/application/engine/configuration/properties/MigrationProperties.javaapplication-engine/src/main/java/com/netgrif/application/engine/elastic/service/ElasticCaseService.javaapplication-engine/src/main/java/com/netgrif/application/engine/elastic/service/model/FullTextField.javaapplication-engine/src/main/java/com/netgrif/application/engine/event/GroovyShellFactory.javaapplication-engine/src/main/java/com/netgrif/application/engine/importer/service/Importer.javaapplication-engine/src/main/java/com/netgrif/application/engine/petrinet/domain/roles/ProcessRoleRepository.javaapplication-engine/src/main/java/com/netgrif/application/engine/workflow/domain/repositories/CaseRepository.javaapplication-engine/src/main/java/com/netgrif/application/engine/workflow/service/CaseEventHandler.javaapplication-engine/src/main/java/com/netgrif/application/engine/workflow/service/TaskService.javaapplication-engine/src/main/resources/application-old-dev.propertiesapplication-engine/src/main/resources/application-old.propertiesapplication-engine/src/main/resources/application.yamlapplication-engine/src/test/groovy/com/netgrif/application/engine/TestHelper.groovyapplication-engine/src/test/groovy/com/netgrif/application/engine/action/ActionDelegateTest.groovyapplication-engine/src/test/groovy/com/netgrif/application/engine/action/AssignRemoveTest.groovyapplication-engine/src/test/java/com/netgrif/application/engine/elastic/service/ElasticCaseServiceIntegrationTest.javaapplication-engine/src/test/java/com/netgrif/application/engine/elastic/service/ElasticCaseServiceTest.javaapplication-engine/src/test/resources/application-test.yamlapplication-engine/src/test/resources/petriNets/async_run.xmldocker-compose.ymlnae-object-library/pom.xmlnae-object-library/src/main/java/com/netgrif/application/engine/objects/petrinet/domain/roles/ProcessRole.javanae-object-library/src/main/java/com/netgrif/application/engine/objects/workflow/domain/Case.javanae-object-library/src/main/java/com/netgrif/application/engine/objects/workflow/domain/ProcessResourceId.javanae-object-library/src/main/java/com/netgrif/application/engine/objects/workflow/domain/Task.javanae-spring-core-adapter/pom.xmlnae-spring-core-adapter/src/main/java/com/netgrif/application/engine/adapter/spring/workflow/domain/Task.javanae-user-ce/pom.xmlnae-user-common/pom.xmlpom.xml
renczesstefan
previously approved these changes
Aug 4, 2026
…s filtering, improve action import handling, and remove unused `ProcessResourceId` logic.
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
nae-object-library/src/main/java/com/netgrif/application/engine/objects/workflow/domain/Task.java (2)
188-192: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick winPreserve
_idafter identifier initialization.
setProcessIdentifiercreates a newObjectIdon every non-empty call. A second call changes the task's resource identity. A null or empty call can also leave the old_idpaired with a cleared identifier. Initialize_idonce and reject identifier changes after identity creation.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@nae-object-library/src/main/java/com/netgrif/application/engine/objects/workflow/domain/Task.java` around lines 188 - 192, Update Task.setProcessIdentifier so _id is initialized only once for the first valid non-empty processIdentifier, and reject subsequent attempts to change the identifier after identity creation. Ensure null or empty inputs cannot clear or leave _id inconsistent with the established process identifier.
37-47: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick winAdd legacy
processIdsupport for generated task IDs.
get_id()only usesprocessIdentifier, andprocessIdentifieris never populated unlesssetProcessIdentifier()is called, while legacy writers and existing task storage still useprocessId. KeepprocessIdcompatible and initialize_idfromprocessIdwhenprocessIdentifieris absent.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@nae-object-library/src/main/java/com/netgrif/application/engine/objects/workflow/domain/Task.java` around lines 37 - 47, Update Task.get_id() to fall back to the legacy processId when processIdentifier is absent, and ensure the generated _id is initialized from that fallback. Preserve processIdentifier as the preferred source while keeping existing processId-backed task storage and writers compatible.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@application-engine/src/main/java/com/netgrif/application/engine/event/GroovyShellFactory.java`:
- Around line 69-73: The isProductionClass filter in GroovyShellFactory
currently admits only classes sharing GroovyShellFactory’s code-source URL;
update it to recognize production classes from every configured production
module, including nae-object-library and nae-spring-core-adapter, while still
excluding test classes. Add coverage verifying automatic imports for one type
from each of those modules.
---
Outside diff comments:
In
`@nae-object-library/src/main/java/com/netgrif/application/engine/objects/workflow/domain/Task.java`:
- Around line 188-192: Update Task.setProcessIdentifier so _id is initialized
only once for the first valid non-empty processIdentifier, and reject subsequent
attempts to change the identifier after identity creation. Ensure null or empty
inputs cannot clear or leave _id inconsistent with the established process
identifier.
- Around line 37-47: Update Task.get_id() to fall back to the legacy processId
when processIdentifier is absent, and ensure the generated _id is initialized
from that fallback. Preserve processIdentifier as the preferred source while
keeping existing processId-backed task storage and writers compatible.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 86350b82-6eed-4c1b-8b62-6308a3ec9d67
📒 Files selected for processing (3)
application-engine/src/main/groovy/com/netgrif/application/engine/migration/helpers/CaseMigrationHelper.groovyapplication-engine/src/main/java/com/netgrif/application/engine/event/GroovyShellFactory.javanae-object-library/src/main/java/com/netgrif/application/engine/objects/workflow/domain/Task.java
💤 Files with no reviewable changes (1)
- application-engine/src/main/groovy/com/netgrif/application/engine/migration/helpers/CaseMigrationHelper.groovy
…cement` usage in full-text search normalization
|
Member
|
@coderabbitai please review and approve if its ok. |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
echo '=== Changed files ==='
git diff --name-only HEAD^ HEAD
echo '=== Diff summary ==='
git diff --stat HEAD^ HEAD
echo '=== Full diff for production source and configuration ==='
git diff --find-renames --unified=50 HEAD^ HEAD -- \
application-engine/src/main/groovy/com/netgrif/application/engine/AsyncRunner.groovy \
application-engine/src/main/groovy/com/netgrif/application/engine/petrinet/domain/dataset/logic/action/ActionDelegate.groovy \
application-engine/src/main/java/com/netgrif/application/engine/elastic/service/ElasticCaseService.java \
application-engine/src/main/java/com/netgrif/application/engine/event/GroovyShellFactory.java \
nae-object-library/src/main/java/com/netgrif/application/engine/objects/workflow/domain/ProcessResourceId.java \
nae-object-library/src/main/java/com/netgrif/application/engine/objects/workflow/domain/Task.java \
nae-object-library/src/main/java/com/netgrif/application/engine/objects/workflow/domain/Case.java \
application-engine/src/main/java/com/netgrif/application/engine/workflow/service/TaskService.java \
application-engine/src/main/java/com/netgrif/application/engine/workflow/domain/repositories/CaseRepository.java \
application-engine/src/main/java/com/netgrif/application/engine/petrinet/domain/roles/ProcessRoleRepository.java \
application-engine/src/main/groovy/com/netgrif/application/engine/migration/helpers/CaseMigrationHelper.groovy \
application-engine/src/main/groovy/com/netgrif/application/engine/migration/helpers/TaskMigrationHelper.groovy \
application-engine/src/main/resources/application.yaml \
application-engine/src/main/resources/application-old.properties \
docker-compose.yml
echo '=== Relevant constructor/call-site search ==='
rg -n -C 3 \
'new ProcessResourceId|setProcessIdentifier\s*\(|setProcessId\s*\(|getShortProcessId(?:entifier)?\s*\(|findByNetworkId(?:entifier)?AndObjectId\s*\(|AsyncRunner\s*\(|\.run\s*\(|\.execute\s*\(' \
--glob '*.{java,groovy}' .
echo '=== Async executor bean definitions and usage ==='
rg -n -C 4 'actionsExecutor|TaskExecutor|EnableAsync|`@Async`' \
--glob '*.{java,groovy}' application-engine nae-*Length of output: 114944 🏁 Script executed: #!/bin/bash
set -euo pipefail
target='application-engine/src/main/java/com/netgrif/application/engine/elastic/service/ElasticCaseService.java'
echo '=== ElasticCaseService structure ==='
ast-grep outline "$target" --items all --view expanded
echo '=== Current full-text implementation ==='
rg -n -C 12 \
'normalizeFullTextSearch\s*\(|buildFullText|fullText|escapeWildcardValue|removeDanglingEscapeCharacters' \
"$target"
echo '=== Baseline version of the changed method ==='
git show HEAD^:"$target" | rg -n -C 12 \
'normalizeFullTextSearch\s*\(|buildFullText|fullText|escapeWildcardValue|removeDanglingEscapeCharacters'
echo '=== Full-text test definitions and assertions ==='
rg -n -C 10 \
'full[Tt]ext|wildcard|backslash|\\\\|\\$|normalizeFullTextSearch|escapeWildcardValue' \
--glob '*.{java,groovy}' application-engine/src/test
echo '=== Configuration for full-text fields ==='
rg -n -C 5 'full.?text|fullText' \
--glob '*.{yaml,yml,properties,java,groovy}' application-engine/src/main application-engine/src/testLength of output: 201570 🏁 Script executed: #!/bin/bash
set -euo pipefail
echo '=== Sanitizer definition and uses ==='
sanitizer=$(fd -t f 'ElasticsearchQuerySanitizer\.java$' . | head -n 1)
if [ -z "$sanitizer" ]; then
echo 'ElasticsearchQuerySanitizer.java not found'
exit 1
fi
ast-grep outline "$sanitizer" --items all --view expanded
cat -n "$sanitizer"
echo '=== Current PR diff and whitespace validation ==='
git diff --check HEAD^ HEAD
git diff --word-diff=plain HEAD^ HEAD -- application-engine/src/main/java/com/netgrif/application/engine/elastic/service/ElasticCaseService.java
echo '=== Test changes in this PR, if any ==='
git diff --find-renames --unified=15 HEAD^ HEAD -- application-engine/src/test/java/com/netgrif/application/engine/elastic/service/ElasticCaseServiceTest.java application-engine/src/test/java/com/netgrif/application/engine/elastic/service/ElasticCaseServiceIntegrationTest.java
echo '=== Current repository state ==='
git status --shortLength of output: 8181
The full-text normalization change is consistent with Approved. You are interacting with an AI system. |
renczesstefan
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release
Summary by CodeRabbit
New Features
Bug Fixes
Security