Hardening SDK testing#6
Conversation
7d8ec6f to
0ec6ca7
Compare
|
Warning Review limit reached
More reviews will be available in 40 minutes and 10 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository: nanoframework/coderabbit/.coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe pipeline adds a SmokeTest parity check, rebuilds SmokeTest with both dotnet and MSBuild, and updates versioning settings in ChangesSmokeTest parity validation and versioning
Sequence Diagram(s)sequenceDiagram
participant AzurePipelines
participant VSBuildTask
participant PowerShellTask
participant VerifyParity as Verify-Parity.ps1
participant DotNetBuild as dotnet build
participant MSBuildExe as msbuild.exe
AzurePipelines->>VSBuildTask: build SmokeTest.csproj with /p:Restore=false
AzurePipelines->>PowerShellTask: run Verify-Parity.ps1 -Configuration $(buildConfiguration)
PowerShellTask->>VerifyParity: invoke script
VerifyParity->>DotNetBuild: build net8.0 and capture .nanoresources
VerifyParity->>MSBuildExe: build net472 and capture .nanoresources
VerifyParity->>VerifyParity: compare file names and SHA256 hashes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Add new task in AZDO to build using msbuild task. - Add PS1 to compare nanoresources hash between net472 <--> net8.0 builds.
0ec6ca7 to
004626c
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/SmokeTest/Verify-Parity.ps1`:
- Line 63: The Verify-Parity.ps1 script hardcodes the intermediate output folder
via the resourceDirectory assignment, which ties it to a specific TFM. Update
the logic to query MSBuild for IntermediateOutputPath (or an equivalent
evaluated property) instead of composing obj\<BuildConfiguration>\netnano1.0,
and keep the change localized to the resourceDirectory setup so the script works
across target frameworks.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: nanoframework/coderabbit/.coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: be338f1e-b4b6-4986-80da-7e6774b8fa01
📒 Files selected for processing (2)
azure-pipelines.ymltest/SmokeTest/Verify-Parity.ps1
dd5f0a4 to
ba270e8
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/SmokeTest/Verify-Parity.ps1`:
- Around line 83-88: The parity check in Verify-Parity.ps1 should stop treating
a non-zero toolchain exit as recoverable just because .nanoresources were
generated. Update the conditional around the build result so that Verify-Parity
always fails on any non-zero exit from the toolchain build, and remove the
warning/continue path tied to $resourceFiles.Count in that branch. Keep the
failure behavior centered on the exitCode handling in the build check.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: nanoframework/coderabbit/.coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: d3417a5b-d771-40aa-997f-16b660e8d5e8
📒 Files selected for processing (2)
azure-pipelines.ymltest/SmokeTest/Verify-Parity.ps1
12d63a1 to
a446fae
Compare
a446fae to
ad4ba00
Compare
e2fc19c to
7e94c60
Compare
3a55c9a to
2e4040f
Compare
2e4040f to
7d499cb
Compare
Description
Motivation and Context
How Has This Been Tested?
Screenshots
Types of changes
Checklist: