Switch to pyproject.toml based project setup#69
Open
Daverball wants to merge 1 commit into
Open
Conversation
Member
|
Seems to be a problem with coverall. I think we should remove it as we have 100% coverage. If you want to switch to rust feel free to go. I'm also starting to switch my projects. I quite like it. |
Contributor
Author
I think it was just a temporary network failure, the same job succeeded on the forked repository. Feel free to re-run the failed jobs.
I'm happy to do that in a follow-up PR, for now this is good enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the equivalent changes to morepath made by @henri-hulski .
I did however decide to add
flake8-pyprojectto the development dependencies, so we can put theflake8configuration insidepyproject.tomlas well.Long term it might make more sense to replace black and flake8 with ruff.
I also decided to use
tox-ghinstead of creating a separate runner for every tox environment, since that seems a bit excessive, considering how fast most checks are.This is preparation for adding inline type hints to
reg, I wanted a more modern project configuration, before I start adding type checkers to it.