Skip to content

Document singleton pattern changes in customfields handler. - #1661

Merged
aanabit merged 1 commit into
moodle:mainfrom
paulholden:customfields-singleton
Jul 30, 2026
Merged

Document singleton pattern changes in customfields handler.#1661
aanabit merged 1 commit into
moodle:mainfrom
paulholden:customfields-singleton

Conversation

@paulholden

@paulholden paulholden commented Jul 29, 2026

Copy link
Copy Markdown
Member

See MDL-88176.

Copilot AI review requested due to automatic review settings July 29, 2026 07:21
@netlify

netlify Bot commented Jul 29, 2026

Copy link
Copy Markdown

Deploy Preview for moodledevdocs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4ba5353
🔍 Latest deploy log https://app.netlify.com/projects/moodledevdocs/deploys/6a6b36536791600008e1f56e
😎 Deploy Preview https://deploy-preview-1661--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Documents the change in Moodle 5.2 that moves \core_customfield\handler::create(...) static caching/reset behavior into the base handler, and updates the Custom fields API docs accordingly.

Changes:

  • Added a Moodle 5.2 developer update entry describing the base handler create() caching/reset change (MDL-88176).
  • Updated Custom fields API documentation (current + 5.2) to reflect the base handler’s create() behavior.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
versioned_docs/version-5.2/devupdate.md Adds a 5.2 dev update note about the base customfields handler create() caching/reset change.
versioned_docs/version-5.2/apis/core/customfields/index.md Updates the 5.2 Custom fields API docs to describe the base handler create() behavior.
docs/apis/core/customfields/index.md Updates the current Custom fields API docs to describe the base handler create() behavior.

Comment thread versioned_docs/version-5.2/devupdate.md Outdated
Comment thread versioned_docs/version-5.2/apis/core/customfields/index.md Outdated
Comment thread docs/apis/core/customfields/index.md Outdated

@yerairogo yerairogo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should avoid calling singleton to the handler class to avoid future misconceptions. Otherwise, looks good.
Please address Copilot comments so I can approve it :)

@paulholden

Copy link
Copy Markdown
Member Author

I think we should avoid calling singleton to the handler class to avoid future misconceptions. Otherwise, looks good. Please address Copilot comments so I can approve it :)

Cheers Yerai, applied all Copilot suggestings and also changed the devupdate heading:

Custom fields base handler caching {/* #custom-fields-base-handler-caching */}

@paulholden
paulholden force-pushed the customfields-singleton branch from c9060c6 to 4ba5353 Compare July 30, 2026 11:32

@yerairogo yerairogo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Paul. Looks good to me 👍

@aanabit aanabit left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this PR based on Yerai's review.

@aanabit
aanabit added this pull request to the merge queue Jul 30, 2026
Merged via the queue into moodle:main with commit 5b9d0ed Jul 30, 2026
6 checks passed
@paulholden
paulholden deleted the customfields-singleton branch July 30, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants