Fix magnet snap leaving a gap at low timeline zoom - #1869
Merged
ddennedy merged 1 commit intoJul 19, 2026
Conversation
Member
|
Thank you. I reproduced the bug, and this fixes it. |
Contributor
Author
|
Happy to help :) |
Member
|
I am sorry to report that I have reverted this because it caused a much worse regression: at the default zoom level (and around it) clicking a clip to select it creates a 2-frame transition right of the clip and shifts all clips on the track following the transition increasing the track (sometimes total) duration by 2 frames. Zoomed out a few steps from default, the damage can be difficult to see. |
Contributor
Author
|
No worries thanks for telling me. |
Contributor
Author
|
Problem is fixed here- #1874 Also, it doesn't pass all checks, but that's just because of the github branch I was using, there's no problems with the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
At low timeline zoom, magnet snap can adjust a clip by less than one pixel while changing its frame. The drop path only committed moves when the pixel delta was at least 1, so a one-frame gap could remain after an apparent snap.
This snaps neighboring clip edges in frame space and commits the drop when the rounded frame changes.
Test plan
scaleFactor0.2), magnet on, close a one-frame gap between neighboring clips on the same track; after drop they are frame-exact contiguous (no blank).