fix(analytics): allow capability to offload reportExposure to async thread#85
Merged
Merged
Conversation
rahul-mixpanel
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow passing an executor to report exposure for a feature flag getVariant call.
This Java SDK doesn't really have an established threading pattern, leaving it up to the caller to handle the threading model.
This change attempts to still leave the caller in control of the threading model. Its not optimal that the default behavior at the moment is still that local getVariant calls will still be slow if reportExposure is enabled, because the http result must complete before the method returns. This behavior should still be further discussed.