Use normalizePath for cross-platform path comparisons on Windows#1604
Open
Copilot wants to merge 2 commits into
Open
Use normalizePath for cross-platform path comparisons on Windows#1604Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix path comparisons by using path.resolve() on Windows
Use normalizePath for cross-platform path comparisons on Windows
Jun 23, 2026
eleanorjboyd
approved these changes
Jun 23, 2026
StellaHuang95
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several path-equality checks used
path.normalize()— or worse, comparedpath.resolve()output againstpath.normalize()output. On Windows these differ in drive-letter case and slash direction, causing settings/override and project matching to silently fail.All affected comparisons now route through the existing
normalizePath()helper (slash-normalized + Windows case-folded) on both sides.Changes
settingHelpers.ts/interpreterSelection.ts— fixed the core bug: comparisons of the formpath.resolve(ws, s.path) === path.normalize(project). Both sides now normalized, fixing pythonProjects override lookups (env/package manager resolution, add/remove/rename) on Windows.projectManager.ts,creators/existingProjects.ts,creators/autoFindProjects.ts,terminal/terminalManager.ts,views/utils.ts— migrated remaining equality checks and map keys tonormalizePath()for case-insensitive matching.path.normalize()(drive-root/depth validation,dirnamemanipulation,fileNameUtilswhich depends onpath.sep).views/utils.removablecovering Windows drive-case/slash equivalence and POSIX case-sensitivity.Example
The
findEnvironmentByPathmethods named in the issue already usenormalizePath(); this change extends that convention to the remaining comparison sites.Fixes #1181