Update tooling deps: npm/json and devcontainer lock#4534
Closed
MasterTLF wants to merge 2 commits into
Closed
Conversation
Install latest npm and json in _scripts and add the devcontainer feature lockfile. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to make local tooling/devcontainer setup more reproducible by capturing dependency/feature resolution state in-repo (devcontainer feature lock + _scripts npm deps/lock).
Changes:
- Added
.devcontainer/devcontainer-lock.jsonto pin resolved devcontainer feature versions/digests. - Updated
_scripts/package.jsonto includejsonandnpmas devDependencies. - Added
_scripts/package-lock.jsonto lock_scriptsdependency resolution.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .devcontainer/devcontainer-lock.json | New lockfile pinning devcontainer feature resolutions. |
| _scripts/package.json | Adds _scripts devDependencies (json, npm). |
| _scripts/package-lock.json | New lockfile capturing _scripts dependency graph. |
Files not reviewed (1)
- _scripts/package-lock.json: Generated file
Format _scripts/package.json and drop unused npm devDependency, keeping json only. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analysis
The session updated local runtime/tooling versions (Node via nvm, npm/json via npm), but repository-tracked tooling deps in
_scriptsstill reflected older state and had no lockfile.To make the tooling update reproducible in this repo, dependency versions and lock data need to be captured in source control.
Fix
Added
jsonas a devDependency in_scripts/package.json, generated_scripts/package-lock.json, and added.devcontainer/devcontainer-lock.jsonto pin devcontainer feature resolutions.Copilot Checklist
I successfully ran these commands at the end of my session, and they completed without error: