feat: load template config from external packages#2819
Open
tido64 wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
platform: Android
This comment was marked as resolved.
This comment was marked as resolved.
tido64
force-pushed
the
tido/dynamic-templates
branch
from
deb7f09 to
e8c9f42
Compare
Allows initializing and configuring existing apps to support additional platforms provided by external packages.
tido64
force-pushed
the
tido/dynamic-templates
branch
from
e8c9f42 to
ee075b3
Compare
JasonVMo
approved these changes
Jun 16, 2026
JasonVMo
left a comment
JasonVMo
left a comment
There was a problem hiding this comment.
Generally looks good, one question for follow up but approving in case you think the ordering is correct as it stands.
| }), | ||
| dependencies: { | ||
| ...dependencies, | ||
| ...platformConfig.dependencies, |
There was a problem hiding this comment.
Should the order of these two be reversed? In other words, should the platform config be a baseline with the dependencies taking precedence?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows initializing and configuring existing apps to support additional platforms provided by external packages.
Part of #2211.
Platforms affected
Test plan
Configure example app to add web support:
cd packages/app/example node ../scripts/configure.mjs -p web --forceVerify that:
build:webscript was added topackage.jsonreact-native-webwas added underdependenciesweb/index.htmlwas created