Skip to content

Use a single 10-minute timeout for all VS Code integration tests#3323

Open
minestarks wants to merge 1 commit into
mainfrom
minestarks/long-timeouts
Open

Use a single 10-minute timeout for all VS Code integration tests#3323
minestarks wants to merge 1 commit into
mainfrom
minestarks/long-timeouts

Conversation

@minestarks

Copy link
Copy Markdown
Member

Fixes #3267

Short, ad-hoc timeouts could trip on slow machines and cause flaky failures. Timeouts should only guard against hung tests, never be short enough for a slow machine to hit.

@minestarks minestarks requested review from billti and idavis as code owners June 12, 2026 18:02
@amcasey

amcasey commented Jun 15, 2026

Copy link
Copy Markdown
Member

Is there a danger the entire test run will time out and we won't get useful results?

@minestarks

minestarks commented Jun 15, 2026

Copy link
Copy Markdown
Member Author

Is there a danger the entire test run will time out and we won't get useful results?

Yes, the entire test run could time out if we have enough tests, but I would call that still a useful result, because you'd be able to see from the logs that all your tests are timing out.

@amcasey

amcasey commented Jun 15, 2026

Copy link
Copy Markdown
Member

Is there a danger the entire test run will time out and we won't get useful results?

Yes, the entire test run could time out if we have enough tests, but I would call that still a useful result, because you'd be able to see from the logs that all your tests are timing out.

As we discussed offline, some CI systems don't give you artifacts if the whole run times out since artifact upload has to happen within the timeout period. I don't know if that's true of this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI failure: windows-latest (26464086886) (Timeout in debugger tests)

3 participants