feat: cmake support#8
Open
FoxMoss wants to merge 6 commits into
Open
Conversation
Author
|
@microsoft-github-policy-service agree |
Author
|
Just checked, seems to be related to #7 will update the code once that gets merged. |
Kamilcuk
reviewed
May 2, 2026
Kamilcuk
reviewed
May 2, 2026
SIGFUN
suggested changes
May 4, 2026
SIGFUN
left a comment
SIGFUN
left a comment
Contributor
There was a problem hiding this comment.
A few stylistic comments and one question. Thanks for doing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for CMake so I can intergrate this library downstream via FetchContent.
I ended up having to remove the following build flags:
Global:
-Wstack-protector-WundefGNU (15.2.1):
-Wformat-truncation=2-Wduplicated-branchesClang (22.1.3):
-fbounds-safety-Wno-duplicate-decl-specifierOn both the Makefile & CMake to get it to build properly, not sure if this is a compile version difference issue would love to get to the bottom of this.