Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/deploy-docs-pages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,8 @@ jobs:
steps:
- name: Configure GitHub Pages
uses: actions/configure-pages@v5
with:
enablement: true
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this will work? As per the Github docs - this option requires a token other than GITHUB_TOKEN to be provided.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct — I misread the docs. actions/configure-pages requires administration:write (PAT or GitHub App) to provision the Pages site; with only GITHUB_TOKEN, enablement: true will still 403. So this two-line diff is effectively a no-op.

Two real paths:

  1. Close this PR and have an admin flip Settings → Pages → Source: GitHub Actions once. One-time, no secret to maintain, cleanest.
  2. Add a PAGES_DEPLOY_TOKEN repo secret with admin:write and pass it via with.token here.

I'd lean (1) unless we expect this workflow to be cloned to new repos. Which would you prefer? Happy to push (2) or close in favor of (1).


- name: Deploy to GitHub Pages
id: deployment
Expand Down
Loading