Apply CMake best practices and remove stale references

[bmehta001]

Pure build/project cleanup

CMake improvements (3 files)

Cleanup / CMake hygiene

• add LANGUAGES C CXX to the top-level project() call
• switch build/config logging to message(STATUS ...) instead of bare message(...)
• Fix message(FATAL_ERROR, ...) comma bug (invalid CMake syntax)
• fix if(EXISTS ...) quoting in lib/, tests/functests/, and tests/unittests
• simplify cross-version file copies to configure_file(... COPYONLY)
• remove stale Visual Studio project/header references
• update VS toolset fallback logic in Solutions/before.targets and Solutions/build.MIP.props
• Update MATSDK_API_VERSION from 3.4 to 3.10 to match recent releases
• Remove empty compiler-id blocks (Clang/Intel/MSVC with no content); GCC -fPIC flags preserved
• Remove commented-out bondlite test block and stale TODO comments
• Remove duplicate include_directories entry

Visual Studio project cleanup (8 files)

• Remove stale header references that no longer exist in the repo:
  • targetver.h (SampleCpp, SampleCppMini)
  • LogManagerV1.hpp (Shared.vcxitems)
  • MockILocalStorageReader.hpp (UnitTests.vcxproj)
  • SanitizerBaseTests.cpp (FuncTests.vcxproj)
• Modernize VS toolset: use `` fallback instead of hardcoded v141 (Solutions/before.targets, build.MIP.props)

Packaging

• keep the package install-dir overrides that Debian/RPM packaging expects
• adjust packaging messages / cleanup so the CMake changes stay behavior-correct

[lalitb]

see comments.

[Copilot]

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 7 comments.

Comments suppressed due to low confidence (2)

tests/unittests/CMakeLists.txt:84

• The appended privacyguard test source paths are unquoted. If ${CMAKE_SOURCE_DIR} contains spaces, these will be split into multiple arguments and break the build. Quote each ${CMAKE_SOURCE_DIR}/... path in this list(APPEND SRCS ...) block.

if(EXISTS "${CMAKE_SOURCE_DIR}/lib/modules/privacyguard/" AND BUILD_PRIVACYGUARD)
  add_definitions(-DHAVE_MAT_PRIVACYGUARD)
  list(APPEND SRCS
  ${CMAKE_SOURCE_DIR}/lib/modules/privacyguard/tests/unittests/InitializationConfigurationTests.cpp
  ${CMAKE_SOURCE_DIR}/lib/modules/privacyguard/tests/unittests/PrivacyConcernEventTests.cpp
  ${CMAKE_SOURCE_DIR}/lib/modules/privacyguard/tests/unittests/PrivacyConcernMetadataProviderTests.cpp
  ${CMAKE_SOURCE_DIR}/lib/modules/privacyguard/tests/unittests/PrivacyGuardTests.cpp
  ${CMAKE_SOURCE_DIR}/lib/modules/privacyguard/tests/unittests/SystematicSamplerTests.cpp

tests/unittests/CMakeLists.txt:96

• The sanitizer test source paths added here are unquoted. If ${CMAKE_SOURCE_DIR} contains spaces, the paths can be mis-parsed as multiple arguments. Quote each ${CMAKE_SOURCE_DIR}/... entry when appending to SRCS.

if(EXISTS "${CMAKE_SOURCE_DIR}/lib/modules/sanitizer/" AND BUILD_SANITIZER)
  list(APPEND SRCS
  ${CMAKE_SOURCE_DIR}/lib/modules/sanitizer/tests/unittests/SanitizerJwtTests.cpp
  ${CMAKE_SOURCE_DIR}/lib/modules/sanitizer/tests/unittests/SanitizerProviderTests.cpp
  ${CMAKE_SOURCE_DIR}/lib/modules/sanitizer/tests/unittests/SanitizerSitePathTests.cpp
  ${CMAKE_SOURCE_DIR}/lib/modules/sanitizer/tests/unittests/SanitizerStringUtilsTests.cpp
  ${CMAKE_SOURCE_DIR}/lib/modules/sanitizer/tests/unittests/SanitizerUrlTests.cpp
  ${CMAKE_SOURCE_DIR}/lib/modules/sanitizer/tests/unittests/SanitizerTrieTests.cpp
  ${CMAKE_SOURCE_DIR}/lib/modules/sanitizer/tests/unittests/SPOPasswordTests.cpp

[bmehta001]

Addressed in 1de44ae: quoted all 23 ${CMAKE_SOURCE_DIR}/... paths inside list(APPEND SRCS ...) blocks across both ests/unittests/CMakeLists.txt and ests/functests/CMakeLists.txt (including the privacyguard + sanitizer blocks not explicitly flagged but sharing the same hazard). Re-requesting Copilot review.

[Copilot]

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.

[bmehta001]

Addressed Copilot round 2: dropped the speculative v145 PlatformToolset mapping from Solutions/before.targets + Solutions/build.MIP.props (337028a). Replied on the -ffast-math thread explaining the removal was intentional (commit 704d29b, SDK isn't FP-heavy and -ffast-math brings IEEE-754 reassociation hazards). All 10 Copilot threads on this PR are now resolved.

[Copilot]

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated no new comments.