feat: Developed scripts and Implement ACR deployment #648
Merged
Conversation
chaudhariniraj
requested review from
Avijit-Microsoft,
Prajwal1-Microsoft,
Roopan-Microsoft,
VinaySh-Microsoft,
aniaroramsft,
dgp10801,
nchandhi and
toherman-msft
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the infrastructure and tooling to provision an Azure Container Registry (ACR) as part of deployment and adds scripts to build/push container images and update Azure Container Apps accordingly.
Changes:
- Added bash and PowerShell scripts to build and push images to ACR using
az acr build, then update Container Apps to the new images. - Updated Bicep/ARM to provision and wire Container Apps to an ACR via managed identity (registry server + identity).
- Removed
containerRegistryEndpointandimageTagparameters from templates and parameter files.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| infra/scripts/acr_build_push.sh | New bash workflow to build/push images in ACR and update Container Apps. |
| infra/scripts/acr_build_push.ps1 | New PowerShell equivalent of the ACR build/push + Container App update workflow. |
| infra/main.parameters.json | Removes now-obsolete parameters for container registry endpoint and image tag. |
| infra/main.waf.parameters.json | Removes now-obsolete parameters for container registry endpoint and image tag (WAF). |
| infra/main.bicep | Wires Container Apps to ACR via managed identity; removes image endpoint/tag parameters; updates app images to a placeholder image. |
| infra/main.json | Regenerated ARM template reflecting Bicep changes (ACR registry wiring + placeholder images). |
| infra/main_custom.bicep | Removes now-obsolete parameters for container registry endpoint and image tag. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chaudhariniraj
changed the title
chaudhariniraj
changed the title
Avijit-Microsoft
previously approved these changes
Jul 3, 2026
Roopan-Microsoft
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information