chore: Update RBAC Configuration to Reference Role IDs (follow-up)#642
Open
ShreyasW-Microsoft wants to merge 3 commits into
Open
chore: Update RBAC Configuration to Reference Role IDs (follow-up)#642ShreyasW-Microsoft wants to merge 3 commits into
ShreyasW-Microsoft wants to merge 3 commits into
Conversation
…w identity Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR continues the RBAC normalization work from #631 by replacing remaining role name references with role definition GUIDs in the Bicep templates and the generated ARM template, improving consistency and avoiding name-based lookups.
Changes:
- Replace
roleDefinitionIdOrNamerole names with role definition GUIDs across container registry, storage, AI services, and App Configuration role assignments. - Preserve role names as inline comments in Bicep for readability.
- Regenerate
infra/main.jsonto reflect the updated RBAC role IDs.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| infra/main.bicep | Updates multiple RBAC roleDefinitionIdOrName entries from role names to role GUIDs (with inline comments). |
| infra/main_custom.bicep | Mirrors the RBAC GUID updates for the custom deployment entrypoint. |
| infra/main.json | Regenerated ARM template reflecting the GUID-based RBAC role assignments. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Update the RBAC configuration so that every role assignment references its Azure built-in role definition ID (GUID) instead of the role display name. Referencing roles by GUID avoids ambiguity and intermittent lookup/deployment failures that can occur when resolving roles by display name.
Scope of changes:
infra/main.bicep— convert allroleDefinitionIdOrNamerole-name values to their role definition GUIDs, each annotated with an inline// Role Namecomment.infra/main_custom.bicep— same conversion, including the previously missedStorage Blob Data Contributorassignment for the workflow managed identity (flagged in review).// Role Nameformat (space after//, no quotes) for readability and consistency with the rest of the files.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
roleDefinitionIdOrNameacross theinfraBicep files references a role definition GUID (no remaining display-name references).// Role Namecomments).Storage Blob Data Contributorassignment now uses GUIDba92f5b4-2d11-453d-a403-e96b0029c9fe.Other Information
Companion change to the Container Migration Solution Accelerator PR applying the same role-ID convention.