Address feedback on localization guidance for automated PRs#40800
Draft
Copilot wants to merge 4 commits into
Draft
Address feedback on localization guidance for automated PRs#40800Copilot wants to merge 4 commits into
Copilot wants to merge 4 commits into
Conversation
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on localization guidance for automated PRs
Address feedback on localization guidance for automated PRs
Jun 13, 2026
Member
|
@copilot - why are so many unrelated localization files in this pr? I just want the guidance so future localization update PRs don't get a million comments about "you shouldn't modify this file" |
…-feedback-localization-guidance
Contributor
Author
Those files were showing up because this branch was based before |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR updates localization guidance to clarify that automated localization-service pull requests are exempt from the contributor-facing rule about filing issues instead of directly editing non-en-US localized files. It also updates branch ancestry so the PR diff only contains the guidance changes.
PR Checklist
Detailed Description of the Pull Request / Additional comments
CONTRIBUTING.mdlocalization guidance to explicitly exclude automated localization-service PRs generated by the localization pipeline..github/copilot-instructions.mdlocalization guidance with the same exemption so automated PR handling is consistent.origin/masterinto this branch so unrelated localeResources.reswfile changes from the stacked base are no longer included in this PR diff.Validation Steps Performed
python3 tools/devops/validate-copyright-headers.pypython3 tools/devops/validate-localization.pyorigin/mastercontains only:CONTRIBUTING.md.github/copilot-instructions.md