Skip to content

Address feedback on localization guidance for automated PRs#40800

Draft
Copilot wants to merge 4 commits into
masterfrom
copilot/wip-address-feedback-localization-guidance
Draft

Address feedback on localization guidance for automated PRs#40800
Copilot wants to merge 4 commits into
masterfrom
copilot/wip-address-feedback-localization-guidance

Conversation

Copilot AI commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Summary of the Pull Request

This PR updates localization guidance to clarify that automated localization-service pull requests are exempt from the contributor-facing rule about filing issues instead of directly editing non-en-US localized files. It also updates branch ancestry so the PR diff only contains the guidance changes.

PR Checklist

  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated if needed and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated if needed
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

  • Updated CONTRIBUTING.md localization guidance to explicitly exclude automated localization-service PRs generated by the localization pipeline.
  • Updated .github/copilot-instructions.md localization guidance with the same exemption so automated PR handling is consistent.
  • Merged origin/master into this branch so unrelated locale Resources.resw file changes from the stacked base are no longer included in this PR diff.
  • This addresses the stacked PR feedback from: Localization change from build: 149610132 #40799 (comment)
  • Original PR context: Localization change from build: 149610132 #40799

Validation Steps Performed

  • Ran python3 tools/devops/validate-copyright-headers.py
  • Ran python3 tools/devops/validate-localization.py
  • Verified PR three-dot diff vs origin/master contains only:
    • CONTRIBUTING.md
    • .github/copilot-instructions.md

Base automatically changed from user/localization/149610132 to master June 13, 2026 13:24
Copilot AI requested review from Copilot and removed request for Copilot June 13, 2026 13:25
Copilot AI changed the title [WIP] [WIP] Address feedback on localization guidance for automated PRs Address feedback on localization guidance for automated PRs Jun 13, 2026
Copilot AI requested a review from benhillis June 13, 2026 13:26
@benhillis

Copy link
Copy Markdown
Member

@copilot - why are so many unrelated localization files in this pr? I just want the guidance so future localization update PRs don't get a million comments about "you shouldn't modify this file"

Copilot AI commented Jun 13, 2026

Copy link
Copy Markdown
Contributor Author

@copilot - why are so many unrelated localization files in this pr? I just want the guidance so future localization update PRs don't get a million comments about "you shouldn't modify this file"

Those files were showing up because this branch was based before master absorbed localization commit #40799, so the PR three-dot diff still included them. I merged origin/master into this branch in d4add1a, and now the PR diff is only the two guidance files (CONTRIBUTING.md and .github/copilot-instructions.md).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants