Fix race condition when starting a local registry#40797
Open
OneBlue wants to merge 1 commit into
Open
Conversation
6 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses flaky timing when starting the wslc-registry:latest test registry by centralizing registry startup logic in the shared e2e helpers and adding an explicit readiness wait before callers proceed.
Changes:
- Refactors
StartLocalRegistryin the SDK tests (WinRT + COM) to delegate toWSLCE2ETests::StartLocalRegistry. - Updates the shared
WSLCE2ETests::StartLocalRegistryhelper to wait for the registry init process to emit a “listening” message before continuing. - Adds the shared helper header include to the affected test files.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/windows/WslcSdkWinRTTests.cpp | Delegates local registry startup to the shared e2e helper for consistent readiness behavior. |
| test/windows/WslcSdkTests.cpp | Delegates local registry startup to the shared e2e helper for consistent readiness behavior. |
| test/windows/wslc/e2e/WSLCE2EHelpers.cpp | Adds a pre-return readiness wait (based on init process output) to reduce registry startup race/flakiness. |
yao-msft
approved these changes
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This change solves a timing issue by actually waiting for the newly created local registry to have the port bound before returning so the caller can immediately call into the registry
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed