Replace GVFS.Service with logon task and file-based repo registry#2020
Draft
tyrielv wants to merge 3 commits into
Draft
Replace GVFS.Service with logon task and file-based repo registry#2020tyrielv wants to merge 3 commits into
tyrielv wants to merge 3 commits into
Conversation
tyrielv
force-pushed
the
tyrielv/local-repo-registry
branch
from
6714021 to
38798d2
Compare
tyrielv
force-pushed
the
tyrielv/local-repo-registry
branch
from
68f0326 to
141d39a
Compare
tyrielv
changed the title
tyrielv
changed the title
tyrielv
force-pushed
the
tyrielv/local-repo-registry
branch
from
b5ae764 to
ac437f2
Compare
Replaces flat {app}\ deployment with versioned Versions\<ver>\ + Current junction.
Eliminates PendingUpgrade staging flow — new version goes to new folder, junction
swaps atomically, mounts continue running from old version until unmounted.
Changes:
- [Files]: Deploy to {app}\Versions\{version}\ instead of {app}\
- [Registry]: PATH points to {app}\Current (junction) instead of {app}\
- [Dirs]: ProgramData under versioned folder
- [Code]: Add CreateOrUpdateCurrentJunction() — creates/updates junction post-install
- [Code]: Add GarbageCollectOldVersions() — keeps 1 most recent old version, deletes older
(skips versions with running mounts detected via Get-Process gvfs.mount | .Path)
- [Code]: Remove KeepMountsRunning variable, IsNormalInstall/IsStagingInstall checks
- [Code]: Remove StagingUpdateService, ShowMountChoiceDialog (no longer needed)
- [Code]: Simplify PrepareToInstall — no mount detection, no staging, just stop service
- [Code]: Update InstallGVFSService to reference {app}\Current\GVFS.Service.exe
- [Code]: Update MountRepos, MigrateConfigAndStatusCacheFiles, WriteOnDiskVersion16CapableFile
to use Current junction paths
- CurStepChanged: Remove staging logic, call CreateOrUpdateCurrentJunction + GarbageCollectOldVersions
- CurUninstallStepChanged: Remove {app}\Current from PATH instead of {app}
Flat-layout migration stub added (detects {app}\GVFS.exe, logs version) but defers
actual file move to future PR to reduce complexity.
Assisted-by: Claude Sonnet 4.5
Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
tyrielv
force-pushed
the
tyrielv/local-repo-registry
branch
from
ac437f2 to
ab7f221
Compare
Fixes 5 critical issues in the Phase 2 versioned-layout installer:
1. Forward reference violation - Move CreateOrUpdateCurrentJunction,
GetFileVersion, IsProcessRunningFromPath, and GarbageCollectOldVersions
before CurStepChanged. Inno Setup Pascal does not allow forward refs.
2. Service starts before junction exists - Create Current junction in
CurStepChanged(ssInstall) BEFORE file extraction, ensuring the junction
exists when InstallGVFSService runs (AfterInstall callback during file
copy). Service binPath references {app}\Current\GVFS.Service.exe.
3. Old PATH entry not cleaned up - On upgrade from flat to versioned layout,
remove legacy {app} PATH entry in CurStepChanged(ssPostInstall). New
entry points to {app}\Current.
4. Non-atomic junction swap - Use Current.new temporary: create junction at
Current.new, rmdir old Current (check ResultCode), rename Current.new to
Current. Eliminates window where Current doesn't exist.
5. Add upgrade test scenarios - Add versioned-fresh-install,
versioned-upgrade, and flat-to-versioned-upgrade scenarios to
.github/workflows/upgrade-tests.yaml with full test implementations.
Assisted-by: Claude Sonnet 4.5
Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
Replace the GVFS.Service Windows service with a simpler architecture: Infrastructure: - LocalRepoRegistry: file-based repo tracking, wire-compatible with old service format. SYSTEM uses ProgramData; per-user uses platform default. Seed-on-first-use copies accessible entries from system registry. - LogonTaskRegistration: machine-wide \GVFS\AutoMount task fires for all interactive users (GroupId S-1-5-4) at logon, runs gvfs service --mount-all. Each user's repos loaded from their own LocalRepoRegistry. - ProjFS boot task: enable-projfs-on-all-drives.ps1 enables ProjFS and attaches PrjFlt on all volumes. Embedded in task XML via build-task-xml.ps1 with SHA-256 hash marker for drift detection. - CLI verb fallbacks: mount/unmount/service verbs fall back to LocalRepoRegistry when the service named pipe is unavailable. - GVFSVerb: silent-success fallback for PrjFlt FilterAttach. - InProcessMount: restore exception safety net in HandleRequest. Installer: - Stop and delete GVFS.Service on upgrade from older versions. - Register \GVFS\AutoMount logon task. - Remove service deployment, install, start from [Files]/[Run]. - Remove PendingUpgrade staging logic and ShowMountChoiceDialog. - Exclude GVFS.Service.exe from payload (layout.bat). Functional tests: - Remove service install/uninstall (no service to test against). - Settings.cs auto-detects user-mode gvfs at %LocalAppData%\VFSForGit\Current. 926 unit tests pass. Assisted-by: Claude Sonnet 4.5 Assisted-by: Claude Opus 4.6 Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
tyrielv
force-pushed
the
tyrielv/local-repo-registry
branch
from
ab7f221 to
adb620b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
One obstacle to automatically updating GVFS is that is requires administrator privileges to install and run.
Currently, GVFS.Service runs as a Windows Service under SYSTEM (high-privilege) account. That means every upgrade has to update the service, because it is a binary that changes in every release, so every upgrade needs administrator privileges.
The service itself currently performs these functions:
gvfs mountand "gvfs unmount" by sending messages on a named pipe to the service from the user-initiated gvfs.exe calls.gvfs serviceverb. These don't change the registry, but read it and perform the given operation.Of these functions, only the ProjFS enable/attach and the PendingUpgrade feature require elevated privileges. PR #2028 replaces PendingUpgrade feature with simpler Current junction, which does not require GVFS.Service support - it's handled entirely in the installer.
Changes
This pull request removes GVFS.Service entirely, replacing it with:
\GVFS\AutoMountfires for all interactive users at logon, runsgvfs service --mount-all(which will mount repos in that user's LocalRepoRegistry)gvfs mountcan also trigger it if needed, for example if a new volume was created during the current user session.Part of Plan UAC-Free Install Modernization (Phase 2)