feat: add AAD auth to azure search writer - #2285
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2285 +/- ##
==========================================
- Coverage 83.70% 83.09% -0.61%
==========================================
Files 327 327
Lines 16788 16802 +14
Branches 1500 1499 -1
==========================================
- Hits 14052 13962 -90
- Misses 2736 2840 +104 ☔ View full report in Codecov by Sentry. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
## Summary Add shared Azure Search authentication configuration for subscription keys, AAD tokens, custom authorization, and custom headers across writer preparation and index list/get/create/statistics APIs. Preserve legacy key-based signatures and add secret-free unit coverage. ## Prompting Intent Recreate the intent of the stale Azure Search AAD PR on current master without breaking callers. Use existing service authentication behavior, retain subscription-key support, reject missing credentials, avoid live-secret tests, and validate security and API compatibility. ## Linked Sources - Original Azure Search AAD PR: microsoft#2285 - AAD cognitive-services foundation: microsoft#1778 ## Rationale Centralize header precedence in the existing cognitive-service path and delegate Azure Search requests to it rather than duplicating authentication logic. Use additive AzureSearchAuth overloads so legacy JVM and Scala signatures remain intact, while request-builder unit tests cover every management API without contacting Azure. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Superseded by #2591, which merged to Thanks @mhamilton723 — this PR identified the gap and sketched the approach. Rather than modify this branch (which had drifted from
The user-facing outcome you were after here is in |
Related Issues/PRs
#xxx
What changes are proposed in this pull request?
Briefly describe the changes included in this Pull Request.
How is this patch tested?
Does this PR change any dependencies?
Does this PR add a new feature? If so, have you added samples on website?
website/docs/documentationfolder.Make sure you choose the correct class
estimators/transformersand namespace.DocTablepoints to correct API link.yarn run startto make sure the website renders correctly.<!--pytest-codeblocks:cont-->before each python code blocks to enable auto-tests for python samples.WebsiteSamplesTestsjob pass in the pipeline.