Skip to content

feat: Refactor infrastructure parameters and add image build scripts#467

Merged
Roopan-Microsoft merged 6 commits into
mainfrom
psl-remotpushimage-codmod
Jul 3, 2026
Merged

feat: Refactor infrastructure parameters and add image build scripts#467
Roopan-Microsoft merged 6 commits into
mainfrom
psl-remotpushimage-codmod

Conversation

@Ragini-Microsoft

Copy link
Copy Markdown
Contributor

Purpose

This pull request introduces a major improvement to the container image build and deployment process by provisioning a dedicated Azure Container Registry (ACR) for every deployment and automating backend/frontend image builds using remote ACR builds. The infrastructure and documentation have been updated to reflect this new workflow, and new post-provision scripts have been added to handle the image build and deployment process. There are also updates to default GPT model versions and several infrastructure parameter cleanups.

Container Image Build & Deployment Automation

  • Added new post-provision scripts (scripts/build_and_push_images.sh and scripts/build_and_push_images.ps1) that remotely build backend and frontend images inside the deployment's ACR using az acr build and update the container apps to use the freshly built images. These scripts ensure the Azure CLI is authenticated and handle all required environment values. [1] [2]
  • Updated infra/main.bicep to provision a dedicated Azure Container Registry per deployment, output relevant ACR and container app information, and configure container apps to use a placeholder image initially, which is replaced by the post-provision script. [1] [2] [3] [4] [5]

Infrastructure Parameter and Template Updates

  • Removed the need for a user-supplied container registry endpoint by making the ACR fully managed and referenced via outputs, and updated parameter files accordingly. [1] [2]
  • Updated imageTag and related descriptions to clarify that tags are applied to images built and pushed remotely, and removed references to manual registry endpoints in documentation and infrastructure. [1] [2]

Documentation Improvements

  • Enhanced deployment documentation to explain the new image build process, expected deployment duration, and Azure CLI sign-in requirements for post-provision scripts.

Model Version Updates

  • Updated default GPT model name and version in infra/main.bicep and infra/main_custom.bicep to gpt-5.1 and 2025-11-13, respectively. [1] [2]

These changes collectively streamline the deployment workflow, reduce manual configuration, and improve reliability and clarity for users and contributors.

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

VishalSh-Microsoft and others added 2 commits July 1, 2026 15:01
…d_and_push_images.sh) for building and pushing container images to ACR.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the deployment workflow to provision a dedicated Azure Container Registry (ACR) per deployment and (intendedly) automate building/pushing the backend/frontend container images via remote ACR builds, while also cleaning up infrastructure parameters and refreshing default GPT model settings.

Changes:

  • Added post-provision scripts to remotely build backend/frontend images with az acr build and update Container Apps to the newly built images.
  • Updated infrastructure to provision a per-deployment ACR, configure Container Apps with a placeholder image, and output ACR/app metadata for scripts.
  • Removed the now-unneeded containerRegistryEndpoint parameter from parameter files and updated docs to reflect the new workflow (plus updated default GPT model name/version in main.bicep).

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
scripts/build_and_push_images.sh New Bash script to build/push images in ACR and update Container Apps.
scripts/build_and_push_images.ps1 New PowerShell script to build/push images in ACR and update Container Apps.
infra/main.waf.parameters.json Removes containerRegistryEndpoint parameter value wiring.
infra/main.parameters.json Removes containerRegistryEndpoint parameter value wiring.
infra/main.json Regenerated ARM template reflecting ACR + placeholder image + outputs.
infra/main.bicep Provisions ACR per deployment, sets placeholder images, adds outputs for post-provision image build/update.
infra/main_custom.bicep Updates default GPT model name (but currently not the version).
docs/DeploymentGuide.md Documents the new image build process and Azure CLI requirements.
docs/CustomizingAzdParameters.md Updates AZURE_ENV_IMAGE_TAG description and removes container registry endpoint env var.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread scripts/build_and_push_images.ps1
Comment thread docs/DeploymentGuide.md Outdated
Comment thread infra/main_custom.bicep

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 8 comments.

Comment thread docs/DeploymentGuide.md Outdated
Comment thread docs/DeploymentGuide.md Outdated
Comment thread docs/DeploymentGuide.md Outdated
Comment thread docs/DeploymentGuide.md Outdated
Comment thread docs/CustomizingAzdParameters.md Outdated
Comment thread scripts/build_and_push_images.sh
Comment thread scripts/build_and_push_images.ps1
Comment thread infra/main.json
Copilot AI review requested due to automatic review settings July 3, 2026 11:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 5 comments.

Comment thread docs/DeploymentGuide.md Outdated
Comment thread docs/DeploymentGuide.md
Comment thread docs/DeploymentGuide.md Outdated
Comment thread scripts/build_and_push_images.ps1
Comment thread infra/main_custom.bicep
@Roopan-Microsoft Roopan-Microsoft merged commit 224d4d2 into main Jul 3, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants