fix(plg_backend_samba): Samba cache expiration issue#977
Open
starryloki wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for the issue where smbcache clears after 30 minutes while a file is still downloading, causing the download to be interrupted. This fix does not affect the original 30-minute smbcache clearing mechanism. #885
The changes are as follows:
Cat() increases backend refs by +1 when opening an SMB file
The returned file handle is wrapped, and refs decrease by -1 upon Close()
When the 30-minute cache expires, it no longer immediately Umount/Logoff
If there are still active file streams at this time, they are only marked as evicted
Umount/Logoff is only executed after the last active file is closed