feat(plg_sftp_backend): use ssh session to rm -r#968
Open
unshade wants to merge 2 commits into
Open
Conversation
…f recursive calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
This modification updates the plg_sftp_backend plugin. When a deletion request targets a directory, the system now prioritizes executing rm -r via SSH.
Fallback Mechanism:
If the SSH execution fails, the process gracefully falls back to the original recursive SFTP method. Any errors encountered during the SSH attempt are logged for debugging.
Why this change?
The previous recursive SFTP approach often resulted in timeouts when deleting large folders due to network overhead. Using SSH rm -r executes the deletion server-side in a single command.
Fix:
Use the SFTP RemoveAll build in function instead of implementing a custom recursive delete.