Updated test guide on CONTRIBUTING.md#4286
Open
giIuis wants to merge 1 commit into
Open
Conversation
* Fix CONTRIBUTING.md to accuratelly describe the steps needed for integration and e2e testing * Fix scripts/build_go_apps.sh to now always runs to completion even if linux only go apps fail on mac. >> Previously, the contributor had to add that by hand
giIuis
force-pushed
the
fix/contributing_test_improvements
branch
from
4c170b2 to
7e2dd46
Compare
t4lz
requested review from
a team and
hank-metalbear
and removed request for
a team
t4lz
reviewed
May 21, 2026
| MIRRORD_TESTS_USE_BINARY=$(pwd)/target/<arch>/debug/mirrord \ | ||
| MIRRORD_LAYER_FILE=$(pwd)/target/<arch>/debug/libmirrord_layer.dylib \ | ||
| MIRRORD_E2E_PRESERVE_FAILED=y | ||
| cargo xtask test-e2e |
Contributor
There was a problem hiding this comment.
should this line be connected with above line?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the contributor had to add that by hand
Quality Checklist:
documentation)