Skip to content

COR-232 Feature gate unnecessary dependencies in mirrord-protocol#4151

Open
DmitryDodzin wants to merge 14 commits into
metalbear-co:mainfrom
DmitryDodzin:dimad/cor-232-feature-gate-unnecessary-dependencies-in-operators-mirrord
Open

COR-232 Feature gate unnecessary dependencies in mirrord-protocol#4151
DmitryDodzin wants to merge 14 commits into
metalbear-co:mainfrom
DmitryDodzin:dimad/cor-232-feature-gate-unnecessary-dependencies-in-operators-mirrord

Conversation

@DmitryDodzin
Copy link
Copy Markdown
Member

Quality Checklist:

  • I have documented new code sufficiently
  • I have checked and updated the relevant existing docs in code, including removing outdated material
  • I have written user-facing website docs for new features, or opened a (sub)issue to do so
  • I have checked and updated existing website docs for changed features
  • I have tested this change and know it succeeds and fails as expected
  • I have written unit tests or purposefully omitted them
  • I have written e2e tests or purposefully omitted them
  • I have explained what this PR introduces and why, and linked to relevant context (e.g. linear issues, related PRs,
    documentation)
  • I have introduced a short, clear and well-formatted changelog entry

@DmitryDodzin DmitryDodzin marked this pull request as ready for review April 14, 2026 15:49
@DmitryDodzin DmitryDodzin requested a review from meowjesty April 19, 2026 17:43
Copy link
Copy Markdown
Member

@meowjesty meowjesty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if we could move these optional impls to separate crates, so we can feature gate the whole crate, instead of doing it with a bunch of cfgs in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants