docs: document mini-block sequencer signatures#54
Conversation
|
Good PR overall — the new section is accurate, well-structured, and the code examples are clearly validated against live endpoints. Two convention issues to fix before merging:
|
ReviewPrevious threads: All three prior comments (heading sentence case ×2, New content looks good overall: the Sequencer Signatures section is accurate, well-structured, and follows the narrative tone expected of a top-level page. The RLP field table, TypeScript/Solidity examples, and One remaining issue: link text in two files uses |
|
All five previous threads are addressed in the latest push:
(Unable to resolve threads programmatically due to token permissions — please resolve manually.) The new content looks correct:
LGTM. |
|
All five prior review threads have been addressed:
The new content looks good:
LGTM. |
Summary
Documents mini-block sequencer signatures, which back the preconfirmation guarantee the docs previously asserted without explanation:
docs/mini-block.md: new "Sequencer Signatures" section — the sequencer signs every mini-block header (keccak256(rlp(header)), raw secp256k1 ECDSA, no EIP-191 prefix,ecrecover-compatible), the key is registered and rotatable on-chain via the SequencerRegistry system contract (0x6342...0006, since Rex5). Includes the 8-field RLP layout table and a "Verifying a Mini-Block Signature" guide with a TypeScript (viem) example, plus rotation guidance (sequencerAtvscurrentSequencer) and a finality caveat. Also fixes the stale "no Merkle roots" header description (mini-block headers carry transaction/receipt roots).docs/dev/read/rpc/eth_subscribe.md: adds the threeminiBlockspayload fields the node serializes but the table omitted:transaction_root,receipt_root,signature(r/s/yParityobject).docs/dev/read/realtime-api.mdanddocs/dev/faq.md: one-line tie-ins linking the preconfirmation claims to the new section.Test plan
miniBlockspayloads on Mainnet and Testnet, recomputed the header hash, recovered the signer, and matchedSequencerRegistry.currentSequencer()/sequencerAt(blockNumber)on both networks.origin/develop(crates/megaeth/realtime/src/mini_block/mini_block.rs,crates/megaeth/utils/src/crypto.rs,crates/megaeth/rpc/src/pubsub.rs) and the SequencerRegistry spec in mega-evm.This PR was generated by an automated agent.