Validate and update links (STF-557) #642
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| name: Links | ||
|
|
||
| on: | ||
| push: | ||
| pull_request: | ||
| schedule: | ||
| - cron: "0 13 * * 1" # weekly, to catch external link rot without a commit | ||
| workflow_dispatch: | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| linkChecker: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| with: | ||
| persist-credentials: false | ||
|
|
||
| - name: Setup mise | ||
| uses: jdx/mise-action@6d1e696aa24c1aa1bcc1adea0212707c71ab78a8 # v3.6.1 | ||
| with: | ||
| install: false | ||
|
|
||
| # Install only lychee (not the repo's full toolchain) and run the check. | ||
| - name: Check links | ||
| env: | ||
| MISE_AUTO_INSTALL: "false" | ||
| run: | | ||
| mise install lychee | ||
| mise run check-links |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,6 +9,7 @@ | |
| .claude | ||
| .gh-pages | ||
| .idea | ||
| .lycheecache | ||
| docs/.hugo_build.lock | ||
| docs/public/ | ||
| .pmd | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,67 @@ | ||||||
| # Lychee link checker configuration | ||||||
| # https://lychee.cli.rs/#/usage/config | ||||||
| # | ||||||
| # Run locally with: | ||||||
| # lychee './**/*.md' './src/**/*.java' './pom.xml' | ||||||
|
|
||||||
| # Include URL fragments in checks | ||||||
| include_fragments = true | ||||||
|
|
||||||
| # Don't allow any redirects, so links that have moved are surfaced and updated | ||||||
| # to their canonical destination. | ||||||
| max_redirects = 0 | ||||||
|
|
||||||
| # Accept these HTTP status codes | ||||||
| # 100-103: Informational responses | ||||||
| # 200-299: Success responses | ||||||
| # 403: Forbidden (some sites use this for rate limiting) | ||||||
| # 429: Too Many Requests | ||||||
| # 500-599: Server errors (temporary issues shouldn't fail CI) | ||||||
| # 999: LinkedIn's custom status code | ||||||
| accept = ["100..=103", "200..=299", "403", "429", "500..=599", "999"] | ||||||
|
|
||||||
| # Exclude URL patterns from checking (treated as regular expressions) | ||||||
| exclude = [ | ||||||
| '^file://', | ||||||
| # Live / auth-gated endpoints that appear as string literals or require login | ||||||
| '^https://geoip\.maxmind\.com', | ||||||
| '^https://geolite\.info', | ||||||
| '^https://minfraud\.maxmind\.com', | ||||||
| '^https://sandbox\.maxmind\.com', | ||||||
| '^https://updates\.maxmind\.com', | ||||||
| '^https://www\.maxmind\.com/en/accounts/', | ||||||
| 'https://www\.maxmind\.com/en/account/login', | ||||||
| # XML namespace identifiers in pom.xml (not real links) | ||||||
| '^http://www\.w3\.org/', | ||||||
| '^http://maven\.apache\.org/', | ||||||
| '^https://maven\.apache\.org/xsd/', | ||||||
| '^http://java\.sun\.com/', | ||||||
| '^http://schemas\.', | ||||||
| # Maven property placeholder in a build-time download URL (not a real link) | ||||||
| 'japicmp\.baselineVersion', | ||||||
| # dev.maxmind.com docs render anchors client-side, so lychee cannot verify | ||||||
| # the #schema-... fragment even though the page (a clean 200) contains it. | ||||||
| '^https://dev\.maxmind\.com/minfraud/api-documentation/responses/#', | ||||||
| # Placeholders / local | ||||||
| '^https?://example\.(com|org|net)', | ||||||
| '^http://localhost', | ||||||
|
There was a problem hiding this comment. The pattern
Suggested change
Member
Author
There was a problem hiding this comment.
— Claude (posted on Greg's behalf) |
||||||
| '127\.0\.0\.1', | ||||||
| ] | ||||||
|
|
||||||
| # Exclude file paths from getting checked (treated as regular expressions) | ||||||
| exclude_path = [ | ||||||
| '(^|/)node_modules/', | ||||||
| '(^|/)target/', | ||||||
| '(^|/)\.git/', | ||||||
| # Test code and fixtures contain example URLs (e.g. www.example.com), not ours | ||||||
| '(^|/)src/test/', | ||||||
| # Changelog: historical entries are preserved as-is, not rewritten | ||||||
| '(^|/)CHANGELOG\.md$', | ||||||
| ] | ||||||
|
|
||||||
| # Cache results for 1 day to speed up repeated checks | ||||||
| cache = true | ||||||
| max_cache_age = "1d" | ||||||
|
|
||||||
| # Skip missing input files instead of erroring | ||||||
| skip_missing = true | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,17 +7,17 @@ | |
| <version>4.3.0</version> | ||
| <name>MaxMind minFraud API</name> | ||
| <description>MaxMind minFraud Score, Insights, Factors and Report Transaction API</description> | ||
| <url>https://dev.maxmind.com/minfraud/</url> | ||
| <licenses> | ||
| <license> | ||
| <name>Apache License, Version 2.0</name> | ||
| <url>https://www.apache.org/licenses/LICENSE-2.0.html</url> | ||
| <distribution>repo</distribution> | ||
| </license> | ||
| </licenses> | ||
| <organization> | ||
| <name>MaxMind, Inc.</name> | ||
| <url>https://www.maxmind.com/en/home</url> | ||
| </organization> | ||
| <scm> | ||
| <url>https://github.com/maxmind/minfraud-api-java</url> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,7 +8,8 @@ | |
|
|
||
| /** | ||
| * Custom inputs to be used in | ||
| * <a href="https://www.maxmind.com/en/accounts/current/minfraud-interactive/custom-rules">Custom | ||
| * Rules</a>. | ||
| * In order to use custom inputs, you must set them up from your account portal. | ||
| */ | ||
| public final class CustomInputs extends AbstractModel { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,7 +21,7 @@ | |
| * date-time. | ||
| * @param localTime The date and time of the transaction at the UTC offset associated with the | ||
| * device. This is an RFC 3339 date-time. | ||
| * @see <a href="https://dev.maxmind.com/minfraud/track-devices/?lang=en">Device Tracking Add-on</a> | ||
| */ | ||
| public record Device( | ||
| @JsonProperty("confidence") | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,8 +35,8 @@ | |
| * @param inputPointer This is a JSON Pointer to the input that the warning is associated with. For | ||
| * instance, if the warning was about the billing city, the value would be | ||
| * "/billing/city". See | ||
| * <a href="https://datatracker.ietf.org/doc/html/rfc6901">RFC 6901</a> for the | ||
| * JSON Pointer spec. | ||
| */ | ||
| public record Warning( | ||
| @JsonProperty("code") | ||
|
|
@@ -99,7 +99,8 @@ public String getWarning() { | |
| * @return This is a JSON Pointer to the input that the warning is associated with. For | ||
| * instance, if the warning was about the billing city, the value would be "/billing/city". | ||
| * See | ||
| * <a href="https://datatracker.ietf.org/doc/html/rfc6901">RFC 6901</a> for the JSON Pointer | ||
| * spec. | ||
| * @deprecated Use {@link #inputPointer()} instead. This method will be removed in 5.0.0. | ||
| */ | ||
| @Deprecated(since = "4.0.0", forRemoval = true) | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accepting all 5xx status codes (
500..=599) globally will prevent the link checker from detecting genuinely broken links when a server is permanently down or misconfigured. Since lychee has built-in retry logic for transient errors, it is safer to remove500..=599from theacceptlist so that persistent server errors are correctly flagged.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keeping
500..=599inaccept, matching the dev-site and blog-site configs — transient upstream 5xx shouldn't fail link-checking CI.— Claude (posted on Greg's behalf)