Validate and update links (STF-557)#387
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the Lychee link checker configuration (lychee.toml), adds .lycheecache to .gitignore, and updates various outdated or non-HTTPS URLs across README.md, UPGRADING.md, and pom.xml. The review feedback suggests minor improvements to the Lychee configuration, specifically anchoring a URL exclusion pattern with ^ for consistency and expanding the localhost exclusion pattern to support both HTTP and HTTPS.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| '^https://sandbox\.maxmind\.com', | ||
| '^https://updates\.maxmind\.com', | ||
| '^https://www\.maxmind\.com/en/accounts/', | ||
| 'https://www\.maxmind\.com/en/account/login', |
There was a problem hiding this comment.
For consistency with the other URL patterns in the exclude list, and to prevent accidental partial matches, consider anchoring this pattern with ^.
| 'https://www\.maxmind\.com/en/account/login', | |
| '^https://www\.maxmind\.com/en/account/login', |
There was a problem hiding this comment.
These exclude entries are matched against full URLs, so a leading ^ is effectively a no-op here. Left as-is to match the dev-site/blog-site config style.
— Claude (posted on Greg's behalf)
| 'japicmp\.baselineVersion', | ||
| # Placeholders / local | ||
| '^https?://example\.(com|org|net)', | ||
| '^http://localhost', |
There was a problem hiding this comment.
To support both HTTP and HTTPS for local development links (e.g., https://localhost), consider using ^https?://localhost instead of ^http://localhost.
| '^http://localhost', | |
| '^https?://localhost', |
There was a problem hiding this comment.
localhost only appears as an http:// placeholder in this repo, so this is a no-op today; kept to match the shared template. Happy to broaden to https? if desired.
— Claude (posted on Greg's behalf)
oschwald
force-pushed
the
greg/stf-557
branch
2 times, most recently
from
dda00f0 to
0a57c29
Compare
Part of STF-557. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- http://dev.maxmind.com/ -> https://dev.maxmind.com/ (pom.xml) - http://www.apache.org/licenses/LICENSE-2.0.html -> https://www.apache.org/licenses/LICENSE-2.0.html (pom.xml) - http://www.maxmind.com/ -> https://www.maxmind.com/en/home (pom.xml) - https://www.maxmind.com/en/support -> https://support.maxmind.com/knowledge-base (README.md, UPGRADING.md) Part of STF-557. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2 participants
Add a lychee link-checker config (
lychee.toml) and aCI workflow (
.github/workflows/links.yml), and fix stale/redirecting linkssurfaced by running it.
The config mirrors the shared MaxMind setup:
max_redirects = 0so moved linksare surfaced,
500..=599accepted so transient server errors don't fail CI, XMLnamespace identifiers and the japicmp baseline-version placeholder excluded as
false positives, and the
target/build dir plus thesrc/test/resources/MaxMind-DB submodule fixtures excluded from scanning.
Links updated (old -> new):
http://dev.maxmind.com/->https://dev.maxmind.com/(pom.xml)http://www.apache.org/licenses/LICENSE-2.0.html->https://www.apache.org/licenses/LICENSE-2.0.html(pom.xml)http://www.maxmind.com/->https://www.maxmind.com/en/home(pom.xml)https://www.maxmind.com/en/support->https://support.maxmind.com/knowledge-base(README.md, UPGRADING.md)After the fixes, lychee reports:
28 Total, 21 OK, 0 Errors, 7 Excluded.Part of STF-557.
🤖 Generated with Claude Code