chore: add PEP 484 type annotations to animationservice.py#384
Merged
joepal1976 merged 2 commits intoJun 12, 2026
Merged
Conversation
joepal1976
previously approved these changes
Jun 12, 2026
joepal1976
left a comment
Contributor
There was a problem hiding this comment.
Thanks.
That Optional[int] is needed in the first place puts a finger at an ugly code construct which should probably be fixed. But that is a problem with the code and not the type hinting.
The merge-base changed after approval.
joepal1976
approved these changes
Jun 12, 2026
joepal1976
approved these changes
Jun 12, 2026
joepal1976
previously approved these changes
Jun 12, 2026
joepal1976
left a comment
Contributor
There was a problem hiding this comment.
Github is playing silly buggers here...
The merge-base changed after approval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds PEP 484 type annotations to all static methods in
AnimationService.Changes
from typing import OptionalimportMethods annotated
import_bvh_file_as_poseget_max_keyframemake_cyclicget_bone_movement_distancemove_bone_for_all_keyframesduplicate_keyframesduplicate_keyframeget_key_frames_as_dictset_key_frames_from_dictContinues the annotation series from #377 (logservice), #378 (systemservice), #380 (modifierservice), and #381 (assetservice, open).
Generated and verified by Symbiote — autonomous Python annotation engine.