Skip to content

chore: add PEP 484 type annotations to animationservice.py#384

Merged
joepal1976 merged 2 commits into
makehumancommunity:masterfrom
yehorcallmedai-maker:symbiote/plan-animationservice
Jun 12, 2026
Merged

chore: add PEP 484 type annotations to animationservice.py#384
joepal1976 merged 2 commits into
makehumancommunity:masterfrom
yehorcallmedai-maker:symbiote/plan-animationservice

Conversation

@yehorcallmedai-maker

Copy link
Copy Markdown
Contributor

This PR adds PEP 484 type annotations to all static methods in AnimationService.

Changes

  • Added from typing import Optional import
  • Annotated 9 static method signatures with parameter types and return types
  • No logic changes — purely additive metadata

Methods annotated

  • import_bvh_file_as_pose
  • get_max_keyframe
  • make_cyclic
  • get_bone_movement_distance
  • move_bone_for_all_keyframes
  • duplicate_keyframes
  • duplicate_keyframe
  • get_key_frames_as_dict
  • set_key_frames_from_dict

Continues the annotation series from #377 (logservice), #378 (systemservice), #380 (modifierservice), and #381 (assetservice, open).

Generated and verified by Symbiote — autonomous Python annotation engine.

joepal1976
joepal1976 previously approved these changes Jun 12, 2026

@joepal1976 joepal1976 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

That Optional[int] is needed in the first place puts a finger at an ugly code construct which should probably be fixed. But that is a problem with the code and not the type hinting.

@yehorcallmedai-maker yehorcallmedai-maker dismissed joepal1976’s stale review June 12, 2026 10:17

The merge-base changed after approval.

joepal1976
joepal1976 previously approved these changes Jun 12, 2026

@joepal1976 joepal1976 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github is playing silly buggers here...

@yehorcallmedai-maker yehorcallmedai-maker dismissed joepal1976’s stale review June 12, 2026 10:22

The merge-base changed after approval.

@joepal1976 joepal1976 merged commit c49eb8d into makehumancommunity:master Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants