Skip to content

Fix NuGet packaging workflow#4

Merged
magiccodingman merged 1 commit into
mainfrom
agent/fix-nuget-pack-workflow
Jul 19, 2026
Merged

Fix NuGet packaging workflow#4
magiccodingman merged 1 commit into
mainfrom
agent/fix-nuget-pack-workflow

Conversation

@magiccodingman

Copy link
Copy Markdown
Owner

What changed

  • removes --no-build from dotnet pack, which conflicted with the custom target that gathers MagicSettings.Share build output
  • keeps --no-restore so the packaging step does not perform an unnecessary second restore
  • upgrades actions/checkout from v4 to v6
  • upgrades actions/setup-dotnet from v4 to v5

Why

The release workflow failed with:

The 'NoBuild' property was set to true but the 'Build' target was invoked.

The package bundling target needs access to the referenced shared project's build output, so the pack invocation must be allowed to invoke build targets. The action upgrades also remove the Node.js 20 deprecation warning.

Validation

The normal pull-request CI will continue to build and test the solution. The corrected pack path will run when the next v* tag triggers the publishing workflow.

@magiccodingman
magiccodingman marked this pull request as ready for review July 19, 2026 18:32
@magiccodingman
magiccodingman merged commit 35ee487 into main Jul 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant