Prepare trusted NuGet publishing#3
Merged
Merged
Conversation
magiccodingman
marked this pull request as ready for review
July 19, 2026 18:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
MagicSettingsandMagicSettings.ServerMagicSettings.Sharenon-packableMagicSettings.Share.dllinside both public packagesMagicSettings.Sharepackage dependencyreleaseenvironmentWhy
The shared project is an implementation detail used by both public packages. Consumers should receive it automatically rather than installing a third standalone package.
GitHub setup still required
releaseNUGET_USERwith the NuGet profile usernamepublish-nuget.ymland thereleaseenvironmentValidation
The existing CI workflow will build and test the solution on this pull request. The publishing workflow additionally validates package count and package contents when a
v*release tag is pushed after merge.I could not run a local pack in this execution environment because outbound GitHub access and the GitHub CLI were unavailable, so the PR is intentionally left as a draft until CI confirms the build.