Organize source files by feature#2
Merged
Merged
Conversation
magiccodingman
marked this pull request as ready for review
July 19, 2026 16:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reorganizes the merged MagicSettings implementation into readable, navigable source files and feature folders.
The numbered
Source.XX.csfiles made unrelated interfaces, records, services, helpers, and tests difficult to find in Rider, GitHub, generated documentation, and AI-agent source retrieval. This PR replaces that temporary consolidated layout with a normal maintainable C# project structure.What changed
MagicSettings.csfile.Abstractions.Configuration.ControlPlane.Diagnostics.Metadata.Migrations.Runtime.Security.Secrets.MagicSettings.ServerAbstractions.Authentication.Credentials.InMemory.Secrets.Synchronization.Tests
UnitTest1.csscaffold was removed.Readability cleanup
GlobalUsings.csfiles.wiki/source-layout.mdwith placement rules to prevent numbered catch-all files from returning.Behavior impact
This is a structural-only refactor. It intentionally does not change runtime behavior, protocol contracts, public namespaces, or developer-facing APIs.
Validation
GitHub Actions passed on commit
aab4a1fd6db7c22ba253d5e923d6be477d2b15c2:dotnet restore MagicSettings/MagicSettings.slndotnet build MagicSettings/MagicSettings.sln --configuration Release --no-restoredotnet test MagicSettings/MagicSettings.sln --configuration Release --no-buildResult: restore, Release build, and the complete xUnit test suite passed.