Fix/cue playback failure handling#515
Open
markojurkovic wants to merge 2 commits into
Open
Conversation
added 2 commits
July 19, 2026 14:07
Keep late playback errors attached to their originating track and ignore superseded or recoverable seek failures when valid audio follows.
Treat fragment URLs from the same underlying resource as one failed source, avoid repeatedly opening each logical track, and publish only the first fallback stream that opens successfully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve failure handling for CUE and other multi-track sources so recoverable decoder behavior does not produce false track errors, while genuinely failed sources are skipped efficiently.
Changes
Result
CUE tracks that recover from an imperfect seek are no longer incorrectly marked as failed. When a shared multi-track source genuinely cannot be opened, Cog avoids repeating the same expensive probe for every track and advances to the next playable source without presenting failed fallbacks as the current track.
Verification
git diff --check main...fix/cue-playback-failure-handlingpasses.Suggested manual checks