Fixes the broken audio output if bluetooth headset is muted#1198
Draft
MaxHeimbrock wants to merge 1 commit into
Draft
Fixes the broken audio output if bluetooth headset is muted#1198MaxHeimbrock wants to merge 1 commit into
MaxHeimbrock wants to merge 1 commit into
Conversation
Contributor
No changeset foundThis PR modifies the following packages but doesn't include a changeset: Directly changed:
Downstream dependencies (also need a version bump):
Click here to create a changeset The link pre-populates a changeset file with If this change doesn't require a version bump, add the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before you submit your PR
A draft for a specific fix: https://linear.app/livekit/issue/CLT-3070/sdk-platform-audio-when-muting-with-bt-headset-audio-output-is-sampled
When on MacOS I speak to an agent using my Bluetooth Headset (Sony MH1000X) and while the agent speaks I mute my track, the audio system changes modes and output sample rate changes. We currently don't detect this, so the agent audio becomes squeaky and broken.
On Android and iOS this issue does not exist.