Skip to content

Fix failover CI by bypassing mock auth in failover tests#737

Merged
cloudwebrtc merged 2 commits into
mainfrom
copilot/fix-failing-github-actions-job
Jun 30, 2026
Merged

Fix failover CI by bypassing mock auth in failover tests#737
cloudwebrtc merged 2 commits into
mainfrom
copilot/fix-failing-github-actions-job

Conversation

Copilot AI commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

The failover Actions job started failing because the shared livekit/test-server now enforces auth by default, causing failover tests to fail with 401 unauthenticated before retry logic is exercised. This change updates the failover test harness to explicitly opt out of auth for these scenarios.

  • Problem context

    • Failover tests are intended to validate retry/region behavior, not permission enforcement.
    • Placeholder test token now trips server-side auth checks and blocks those paths.
  • Change

    • In tests/api/test_failover.py, update request headers in _call(...) to always include x-lk-mock-skip-auth: true.
    • Keep existing per-test X-Lk-Mock-* directives unchanged and composable.
  • Effect on test behavior

    • Requests reach failover code paths again (healthy, 5xx retry, transport-drop retry, terminal 4xx, discovery failure) instead of terminating on auth.
headers = {
    "authorization": "******",
    "x-lk-mock-skip-auth": "true",
    **directives,
}

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copilot AI changed the title [WIP] Fix failing GitHub Actions job "failover" Fix failover CI by bypassing mock auth in failover tests Jun 30, 2026
Copilot AI requested a review from cloudwebrtc June 30, 2026 11:43
@cloudwebrtc cloudwebrtc marked this pull request as ready for review June 30, 2026 11:44

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@cloudwebrtc cloudwebrtc merged commit 0fc49e1 into main Jun 30, 2026
11 of 12 checks passed
@cloudwebrtc cloudwebrtc deleted the copilot/fix-failing-github-actions-job branch June 30, 2026 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants