fix(#663): adapt psycopg JSON records for Arrow COPY - #665
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #665 +/- ##
==========================================
+ Coverage 77.22% 77.23% +0.01%
==========================================
Files 475 475
Lines 67824 67833 +9
Branches 9322 9322
==========================================
+ Hits 52374 52394 +20
+ Misses 12042 12033 -9
+ Partials 3408 3406 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
cofin
marked this pull request as ready for review
August 1, 2026 16:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
load_from_records()normalized mappings into an Arrow table. JSON mappings became Arrow struct values and were passed back to psycopg COPY as Python dictionaries, which psycopg cannot adapt in text COPY mode. Preparing only after Arrow inference would also normalize heterogeneous JSON object shapes, so psycopg now applies its existing parameter configuration before inference and retains schema-gated preparation for direct Arrow inputs.Closes #663.