Skip to content

fix(js): remove deprecated glob dependency - #145

Merged
konard merged 4 commits into
mainfrom
issue-144-f6b361f5f8d3
Jul 27, 2026
Merged

fix(js): remove deprecated glob dependency#145
konard merged 4 commits into
mainfrom
issue-144-f6b361f5f8d3

Conversation

@konard

@konard konard commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • upgrade archiver from 7.0.1 to 8.0.0, removing the production archiver-utils -> glob@10.5.0 chain
  • migrate ZIP creation to Archiver 8's named ZipArchive API across server, CLI, Google Docs, and large-paste paths
  • add a dependency-tree regression test, Rust archive parity coverage, and a patch changeset
  • keep Rust's Serde default helper compatible with the current stable test-harness dead-code analysis

Fixes #144

Reproduction

Before this change, a downstream production install resolved:

@link-assistant/web-capture
└─┬ archiver@7.0.1
  └─┬ archiver-utils@5.0.2
    └── glob@10.5.0

The new regression test traverses Archiver's production dependency graph from the generated npm lockfile and fails if glob reappears.

Verification

  • npm test -- --runInBand tests/unit/package-runtime-dependencies.test.js tests/integration/archive-default-layout.test.js tests/unit/cli.test.js — 3 suites, 27 tests passed
  • npm run check — lint, formatting, and duplication checks passed (existing warning baseline only)
  • full Jest run — 53 suites and 485 tests passed; browser/Docker-only suites could not run locally because the Playwright browser and Docker service are not installed (CI provisions both)
  • packed the package and installed it into a fresh consumer project — install succeeded with no glob@10.5.0 warning; npm ls glob --omit=dev --all returned an empty tree
  • node scripts/validate-changeset.mjs — passed
  • cargo fmt --all -- --check — passed
  • cargo clippy --all-targets --all-features -- -D warnings — passed
  • cargo test --test integration archive_default_contains_md_html_and_images_folder — passed and verifies the generated ZIP signature

Compatibility

Archiver 8 requires Node >=18; this package already requires Node >=22 <23.

Adding .gitkeep for PR creation (default mode).
This file will be removed when the task is complete.

Issue: #144
@konard konard self-assigned this Jul 27, 2026
@konard konard changed the title [WIP] archiver@7 pulls deprecated glob@10.5.0 into every consumer; archiver@8 removes it fix(js): remove deprecated glob dependency Jul 27, 2026
@konard
konard marked this pull request as ready for review July 27, 2026 05:05
@konard

konard commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator Author

Working session summary

Implemented and finalized issue #144.

  • Upgraded Archiver to v8, removing deprecated glob@10.5.0.
  • Migrated ZIP creation to ZipArchive.
  • Added dependency regression and Rust parity tests.
  • Added the patch changeset.
  • Verified npm packaging, Jest tests, linting, Clippy, multi-OS Rust tests, live integrations, release build, and Docker build.
  • All CI workflows pass.
  • Working tree is clean and branch is current with main.
  • PR is mergeable and marked ready for review.

Pull request #145


This summary was automatically extracted from the AI working session output.

@konard

konard commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator Author

🤖 Solution Draft Log

This log file contains the complete execution trace of the AI solution draft process.

💰 Cost estimation:

  • Model: GPT-5.6 Sol
  • Provider: OpenAI
  • Public pricing estimate: $14.432915

📊 Context and tokens usage:

  • 320.7K / 200K (160%) input tokens, 21.0K / 128K (16%) output tokens

Total: (320.7K + 10.3M cached) input tokens, 21.0K output tokens, $14.432915 cost

🤖 Models used:

  • Tool: OpenAI Codex
  • Requested: gpt-5.6-sol
  • Thinking level: low (~7999 tokens)
  • Model: GPT 5.6 Sol (gpt-5.6-sol)

📎 Log file uploaded as Gist (3759KB)


Now working session is ended, feel free to review and add any feedback on the solution draft.

@konard
konard merged commit 49eb0e5 into main Jul 27, 2026
21 checks passed
@konard

konard commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator Author

🎉 Auto-merged

This pull request has been automatically merged by hive-mind.

  • All CI checks have passed

Auto-merged by hive-mind with --auto-merge flag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

archiver@7 pulls deprecated glob@10.5.0 into every consumer; archiver@8 removes it

1 participant