Move settings files to include the class name.#349
Open
rwb27 wants to merge 1 commit into
Open
Conversation
Barecheck - Code coverage reportTotal: 97%Your code coverage diff: 0.00% ▴ Uncovered files and lines
|
This means that, if the class of a Thing is changed in config, its settings are saved separately. I've had to add an argument to `ThingServerInterface` to pass in the class name. This then touched a bunch of test code, which is updated. I tried a previous, more complicated way of getting the Thing class, but it relied on `ThingServer.things` which may not be populated when it's needed. I've also added a mocked `_get_server` method which raises an error - this should make `MockThingServerInterface` easier to debug.
rwb27
force-pushed
the
add-class-to-settings-file
branch
from
4e40954 to
70ed1aa
Compare
Collaborator
Author
|
The readthedocs build failure seems to be a GitHub issue, it couldn't pull. There's no way to re-run that job (and the local Sphinx job worked). I'm guessing review comments will involve at least one CI re-run, and I'm going to assume that will fix it. If not, we can deal with it then. |
Collaborator
Author
|
I think we might want to swap the filename around so it starts with settings, e.g. Settings-ClassName.json. If/when there are other files in the folder, it seems sensible to me that the LabThings settings files all sit together in a directory listing. Opinions welcome on camel vs snake case - I don't usually name files in camel, but it saves converting the class name... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This means that, if the class of a Thing is changed in config, its settings are saved separately.
I've had to add an argument to
ThingServerInterfaceto pass in the class name. This then touched a bunch of test code, which is updated. I tried a previous, more complicated way of getting the Thing class, but it relied onThingServer.thingswhich may not be populated when it's needed.I've also added a mocked
_get_servermethod which raises an error - this should makeMockThingServerInterfaceeasier to debug.Closes #290