Better event handling#256
Draft
rwb27 wants to merge 1 commit into
Draft
Conversation
This refactors handling of property and action observations. In particular, it: * Introduces a MessageBroker class to handle pub/sub messaging centrally. This eliminates duplicated code from descriptors and should be much clearer. * Adds a `publish` method to the thing server interface for easy publication of events. * No longer errors if events are published before the event loop is active: they are silently ignored. * Removes the option to set properties without emitting an event: this is no longer needed - it was only ever done to suppress errors. * Separates handling of pub/sub messages from websocket protocol considerations. This does not change the websocket protocol. I've updated tests, but have not yet added tests for `MessageBroker`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has rather run away with me. It will need splitting and tidying before merging.
It started out attempting to centralise event handling into a
MessageBrokerclass, which would then mean events don't cause errors if they fire before the event loop starts. This basically worked.It also updated notification-related stuff to use the syntax
thing.properties[name].observe(stream)rather thanthing.observe_property(name, stream)which deduplicated the logic that found the descriptor.Lastly, and most problematically, it attempts to implement the
webthingsubprotocolsub-protocol for websocket messages. This requires a bunch of changes - in particular, the WoT standard has fewer statuses for actions ("cancelled" is gone).I should break it down so that we implement the first one, then the second one, then the third one - ideally in 3 separate PRs.