chore: deprecate the scaling flags

[ToreMerkely]

Marks --include-scaling and --exclude-scaling as deprecated on kosli create environment and on the kosli snapshot command group (where they apply to --auto-environment).

Scaling has no compliance value and is being ratcheted away server-side — see kosli-dev/server#6327. This is the CLI half of the signal: no new adoption, existing users grandfathered.

No behaviour change. Both flags still parse and still send include_scaling in the payload, and the mutual-exclusion check is untouched. What changes is that using either flag now prints a deprecation warning, and MarkDeprecated hides them from --help and the generated docs. The scaling paragraph was dropped from the create environment long description accordingly, since it documented flags that no longer appear.

The Helm chart change is a separate PR.

Checklist

• Docs are autogenerated from CLI help — make sure the help text reflects your changes
• Helm chart (charts/k8s-reporter/) updated, if needed. Note: these changes live in a separate PR
• Terraform provider and related changes (terraform-provider-kosli, terraform-aws-evidence-reporter, terraform-aws-kosli-reporter) updated, if needed

🤖 Generated with Claude Code

[claude]

Claude finished @ToreMerkely's task in 1m 55s —— View job

---

Review — PR #1061: deprecate the scaling flags

• Gather context (diff, DeprecateFlags helper, payload wiring)
• Static analysis
• Review code quality, wording, edge cases, tests
• Post review feedback

Static analysis: go build ./... ✅ · go vet ./cmd/kosli/... ✅ — both clean.

Summary

Clean, well-scoped change. The deprecation approach is idiomatic (MarkDeprecated both warns and hides the flags from --help/generated docs), the mutual-exclusion behaviour is correctly left untouched, and the dropped scaling paragraph in the create environment long description is the right call since those flags no longer surface. Tests were properly updated from golden to goldenRegex to absorb the new deprecation warning lines — including the both-flags-set case where two warnings now precede the mux error. Nice attention to that detail.

One point worth aligning (non-blocking)

Deprecation message vs. "no behaviour change." Posted inline on createEnvironment.go:100. The shared message "Scaling events do not trigger new snapshots" is a present-tense behaviour claim, but --include-scaling's purpose is precisely to make scaling events trigger snapshots, and the PR keeps sending include_scaling in the payload (createEnvironment.go:127-134). For a grandfathered --include-scaling user the statement reads as false. Suggest framing it as deprecation-of-the-flag ("...will be removed in a future version. Scaling events are being phased out and will no longer trigger new snapshots."). Same wording lives in snapshotAutoEnvironment.go:42, so keep the two in sync if you change it.

Minor / optional

• Two ways to deprecate. createEnvironment.go uses the shared DeprecateFlags(cmd, map[...]) helper while snapshotAutoEnvironment.go hand-rolls a loop over PersistentFlags(). The divergence is justified (DeprecateFlags operates on cmd.Flags(), not persistent flags), but if you want the call sites to read identically, consider a DeprecatePersistentFlags variant or having the helper accept a *pflag.FlagSet. Optional. (Already raised in the prior review.)

Nothing blocking. The wording is the only thing I'd nudge before merge.