Skip to content

fix: nested selectors with css modules.#144

Merged
knightedcodemonkey merged 1 commit into
mainfrom
bananas
May 24, 2026
Merged

fix: nested selectors with css modules.#144
knightedcodemonkey merged 1 commit into
mainfrom
bananas

Conversation

@knightedcodemonkey
Copy link
Copy Markdown
Owner

Copilot AI review requested due to automatic review settings May 24, 2026 19:46
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses CSS Modules nested selector support (Issue #142) by pinning the browser CSS runtime and its Lightning CSS WASM dependency to known-compatible versions, and adds an end-to-end regression test to ensure module nesting compiles cleanly in the UI.

Changes:

  • Pin @knighted/css and @knighted/jsx CDN specifiers to fixed versions for consistent runtime behavior.
  • Pin lightningcss-wasm to a verified version to avoid runtime transform option incompatibilities (e.g. drafts.nesting).
  • Add a Playwright test ensuring CSS Modules nesting renders without style compilation failures/compatibility errors.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/modules/preview/render-runtime.js Clarifies Lightning CSS WASM module initialization comment (no functional change).
src/modules/cdn.js Pins CDN import specifiers for @knighted/css, @knighted/jsx, and lightningcss-wasm to prevent version drift/compat issues.
playwright/diagnostics.spec.ts Adds regression coverage for CSS Modules nesting compilation without Lightning WASM compatibility errors.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@knightedcodemonkey knightedcodemonkey merged commit b2f0327 into main May 24, 2026
7 checks passed
@knightedcodemonkey knightedcodemonkey deleted the bananas branch May 24, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support nested selectors for CSS modules

2 participants