fix: nested selectors with css modules.#144
Merged
Merged
Conversation
Owner
knightedcodemonkey
commented
May 24, 2026
- fixes Support nested selectors for CSS modules #142
- related to feat: nested selectors with lightningcss. css#92
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses CSS Modules nested selector support (Issue #142) by pinning the browser CSS runtime and its Lightning CSS WASM dependency to known-compatible versions, and adds an end-to-end regression test to ensure module nesting compiles cleanly in the UI.
Changes:
- Pin
@knighted/cssand@knighted/jsxCDN specifiers to fixed versions for consistent runtime behavior. - Pin
lightningcss-wasmto a verified version to avoid runtime transform option incompatibilities (e.g.drafts.nesting). - Add a Playwright test ensuring CSS Modules nesting renders without style compilation failures/compatibility errors.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/modules/preview/render-runtime.js | Clarifies Lightning CSS WASM module initialization comment (no functional change). |
| src/modules/cdn.js | Pins CDN import specifiers for @knighted/css, @knighted/jsx, and lightningcss-wasm to prevent version drift/compat issues. |
| playwright/diagnostics.spec.ts | Adds regression coverage for CSS Modules nesting compilation without Lightning WASM compatibility errors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.