Skip to content

feat: implement redesigned Gym Support Content and update PageHeader …#172

Merged
peterlipt merged 2 commits into
mainfrom
132-implement-redesigned-sports-field-support-sportpálya-támogatás-page
Jul 25, 2026

Hidden character warning

The head ref may contain hidden characters: "132-implement-redesigned-sports-field-support-sportp\u00e1lya-t\u00e1mogat\u00e1s-page"
Merged

feat: implement redesigned Gym Support Content and update PageHeader …#172
peterlipt merged 2 commits into
mainfrom
132-implement-redesigned-sports-field-support-sportpálya-támogatás-page

Conversation

@DankaMarci

@DankaMarci DankaMarci commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

…for improved subtitle handling

Summary by CodeRabbit

  • New Features

    • The sport support page header now displays a formatted subtitle, and the header can render richer (non-text) content.
  • UI Improvements

    • Simplified and restyled the support page content layout, including cleaner section framing, list styling, and improved callout presentation.
    • Updated the page background to match the new design.
  • Bug Fixes

    • Improved header rendering so subtitle/description works correctly with non-string content types.

@DankaMarci
DankaMarci requested a review from peterlipt July 3, 2026 14:12
@DankaMarci DankaMarci self-assigned this Jul 3, 2026
@DankaMarci DankaMarci linked an issue Jul 3, 2026 that may be closed by this pull request
4 tasks
@vercel

vercel Bot commented Jul 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ehk Ready Ready Preview, Comment Jul 25, 2026 9:57am

Request Review

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 08e63a71-3433-4fc4-bd32-b7ed02e95a94

📥 Commits

Reviewing files that changed from the base of the PR and between 5cf589f and 0f2fb71.

📒 Files selected for processing (1)
  • src/app/(app)/[lang]/sport/sportpalya-tamogatas/page.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/app/(app)/[lang]/sport/sportpalya-tamogatas/page.tsx

📝 Walkthrough

Walkthrough

GymSupportContent.tsx now uses reusable section, paragraph, list, and notice helpers while omitting the description introduction. The page parses the description for the header subtitle, passes shared content to child components, and PageHeader accepts ReactNode values.

Changes

Sportpálya támogatás page redesign

Layer / File(s) Summary
PageHeader prop type widening
src/components/common/PageHeader.tsx
subtitle and description now accept React.ReactNode, with description retained as a subtitle fallback.
Content rendering helpers and sections
src/app/(app)/[lang]/sport/sportpalya-tamogatas/components/GymSupportContent.tsx
Reusable helpers standardize section framing, paragraph and list rendering, and notice styling; the description introduction is removed from the rendered content.
Page wiring and parsed subtitle
src/app/(app)/[lang]/sport/sportpalya-tamogatas/page.tsx
Dictionary content is stored locally, parsed for the PageHeader subtitle, passed to GymSupportContent, and the outer background class is updated.

Estimated code review effort: 2 (Simple) | ~15 minutes

Possibly related issues

Suggested reviewers: peterlipt

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main changes: redesigned Gym Support Content and updated PageHeader subtitle handling.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 132-implement-redesigned-sports-field-support-sportpálya-támogatás-page

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
src/components/common/PageHeader.tsx (1)

69-69: 🔒 Security & Privacy | 🟡 Minor | ⚡ Quick win

Pass a readable email color into the sport support header subtitle The sport support description already contains email addresses in both dictionaries, and parseFormattedText(content.description) renders them with #862633 on the same #862633 banner, making those links unreadable. Pass a light emailColor here, or let PageHeader enforce a banner-safe link color.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/components/common/PageHeader.tsx` at line 69, The sport support header
subtitle is rendering email links with a dark color that matches the banner
background, making them unreadable. Update the PageHeader subtitle rendering
path so the email/link color is light and readable on the `#862633` banner,
either by passing a banner-safe `emailColor` into
`parseFormattedText(content.description)` or by having `PageHeader` enforce a
contrast-safe link color for this section.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@src/components/common/PageHeader.tsx`:
- Line 69: The sport support header subtitle is rendering email links with a
dark color that matches the banner background, making them unreadable. Update
the PageHeader subtitle rendering path so the email/link color is light and
readable on the `#862633` banner, either by passing a banner-safe `emailColor`
into `parseFormattedText(content.description)` or by having `PageHeader` enforce
a contrast-safe link color for this section.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 966c1854-4639-4188-b161-069e206f17d9

📥 Commits

Reviewing files that changed from the base of the PR and between 2cbebd5 and 5cf589f.

📒 Files selected for processing (3)
  • src/app/(app)/[lang]/sport/sportpalya-tamogatas/components/GymSupportContent.tsx
  • src/app/(app)/[lang]/sport/sportpalya-tamogatas/page.tsx
  • src/components/common/PageHeader.tsx

@peterlipt
peterlipt merged commit 17b8ee4 into main Jul 25, 2026
3 checks passed
@peterlipt
peterlipt deleted the 132-implement-redesigned-sports-field-support-sportpálya-támogatás-page branch July 25, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Redesigned Sports Field Support (Sportpálya támogatás) Page

2 participants