fix(keyboard): track media key press state - #60
Merged
Conversation
esphynox
marked this pull request as ready for review
July 30, 2026 23:47
esphynox
force-pushed
the
fix/media-key-pressed-state
branch
from
July 30, 2026 23:49
693d2ac to
9f5edb0
Compare
esphynox
force-pushed
the
fix/media-key-pressed-state
branch
from
July 30, 2026 23:57
9f5edb0 to
69d468a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix media keycaps so they render their pressed state from live media-key events and from settings previews.
Root cause: capture only forwarded media-key down events, and the keycap factory discarded
MediaKeyEvent.isPressedby hardcoding media keycaps as unpressed. The keyboard visualizer now receives recognized media-key releases and tracks media-key groups so key-up updates the existing rendered group instead of creating a disconnected release.Tests
tuist generatexcodebuild test -project Keyty.xcodeproj -scheme Keyty -destination 'platform=macOS'xcodebuild test -project Keyty.xcodeproj -scheme Keyty -destination 'platform=macOS' -only-testing:KeytyTests/KeycapEventCoordinatorTests -only-testing:KeytyTests/KeycapItemFactoryTests -only-testing:KeytyTests/KeyboardSettingsPreviewTestsRun project commands from
Apps/Keyty.UI Changes
Media keycaps now show the pressed visual state while held, then update to unpressed on key-up. No screenshots attached.
Documentation
Release Notes
Fixed media keycaps so playback, brightness, and volume keys visibly press and release in the keyboard overlay.