fix(developer): prevent clone of legacy keyboards with no source#16111
Open
mcdurdin wants to merge 1 commit into
Open
fix(developer): prevent clone of legacy keyboards with no source#16111mcdurdin wants to merge 1 commit into
mcdurdin wants to merge 1 commit into
Conversation
If a Keyman Cloud keyboard is legacy and has no source available, make this more obvious to the author when they attempt to clone it. Add also messages to help the author complete the other required steps to clone a keyboard. Fixes: #15606 Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
ermshiperete
approved these changes
Jun 23, 2026
| obj: TJSONObject; | ||
| begin | ||
| try | ||
| val := TJSONObject.ParseJSONValue(body); |
Contributor
There was a problem hiding this comment.
Do we have to free val ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a Keyman Cloud keyboard is legacy and has no source available, make this more obvious to the author when they attempt to clone it. Add also messages to help the author complete the other required steps to clone a keyboard.
Fixes: #15606
Test-bot: skip