Fix bug causing broken login state w/ malformed cookie - #229
Open
jmann345 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: If a cookie was pasted with surrounding text, it would be accepted as valid if it contained
csrftoken=andLEETCODE_SESSION=but break when pasted in, causing leetcode.nvim to be in a broken state where I had to manually edit the cookie file in order to log inFix: Strip token to just the line containing
csrftokenandLEETCODE_SESSIONand aCookiebuilt from just that line.Note: This fix may not apply for cookies malformed in other ways, but it fixed the case where I accidentally pasted surrounding text from the cookie in my web browser. A more robust solution for gracefully handling all types of malformed cookie text and recovering when possible exists.
Validation: Logged out, pasted in the same malformed cookie text i pasted in earlier, and had a successful login. Also verified that correctly-formed cookie text still works.