kip-311: split P2P activation between the fork block and node upgrade - #129
Open
hyunsooda wants to merge 1 commit into
Open
kip-311: split P2P activation between the fork block and node upgrade#129hyunsooda wants to merge 1 commit into
hyunsooda wants to merge 1 commit into
Conversation
Backwards Compatibility says legacy P2P behavior, including static AuthorizedNodes, continues unchanged until the fork block. Implementations cannot honor that for the node-local rules: AuthorizedNodes is removed outright, and gating discovery, dialing and peer budgets on the fork block would make every CN re-peer at the one block where consensus depends on them already being online. Split activation by what each rule depends on instead. R4 and R6 read AddressBookV2 and apply at the fork block; R1, R2, R3 and R5 are node-local and apply at node upgrade. Rejected: gate every rule on the fork block | forces a network-wide re-peer at the fork block, and kbn has no chain to read a height from Rejected: frame this as R2 contradicting Backwards Compatibility | R2 can be read as implicitly post-fork like R1, so the mismatch is with the implementation, not within the document Confidence: high Scope-risk: narrow
hyunsooda
force-pushed
the
kip-311-p2p-activation-scope
branch
from
July 28, 2026 03:47
65ca676 to
c1dd5fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Backwards Compatibility says legacy P2P behavior, including static
AuthorizedNodes, continues unchanged until the fork block. Implementations cannot honor that for the node-local rules:AuthorizedNodesis removed outright, and gating discovery, dialing and peer budgets on the fork block would make every CN re-peer at the one block where consensus depends on them already being online.Activation is now split by what each rule depends on: R4 and R6 read
AddressBookV2and apply at the fork block; R1, R2, R3 and R5 are node-local and apply at node upgrade.Types of changes
Checklist
I have read the CLA Document and I hereby sign the CLAin first time contributionRelated issues
Further comments